From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0dB1-0002hw-So for qemu-devel@nongnu.org; Thu, 04 Jun 2015 17:59:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0dAx-0008WA-PD for qemu-devel@nongnu.org; Thu, 04 Jun 2015 17:59:51 -0400 Received: from mail-qc0-x22b.google.com ([2607:f8b0:400d:c01::22b]:36503) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0dAx-0008W6-Lm for qemu-devel@nongnu.org; Thu, 04 Jun 2015 17:59:47 -0400 Received: by qcxw10 with SMTP id w10so23451840qcx.3 for ; Thu, 04 Jun 2015 14:59:47 -0700 (PDT) From: Don Slutz Message-ID: <5570CA50.3080206@Gmail.com> Date: Thu, 04 Jun 2015 17:59:44 -0400 MIME-Version: 1.0 References: <557068F1.1030400@m2r.biz> In-Reply-To: <557068F1.1030400@m2r.biz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [Xen-devel] qemu mainline regression with xen-unstable: unable to start QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabio Fantoni , "qemu-devel@nongnu.org" , xen-devel , Stefano Stabellini , Anthony PERARD , Ian Campbell On 06/04/15 11:04, Fabio Fantoni wrote: > Today after trying xen-unstable build (tested many hours) of some days > ago I tried update qemu to latest development version (from git master > commit 6fa6b312765f698dc81b2c30e7eeb9683804a05b) and seems that there is > a regression: >> xl create /etc/xen/W7.cfg >> Parsing config from /etc/xen/W7.cfg >> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an >> error message from QMP server: QMP input object member 'id' is unexpected >> libxl: error: libxl_qmp.c:715:libxl__qmp_initialize: Failed to connect >> to QMP > This is caused by: commit 65207c59d99f2260c5f1d3b9c491146616a522aa Author: Markus Armbruster Date: Thu Mar 5 14:35:26 2015 +0100 monitor: Drop broken, unused asynchronous command interface > DomU is working but operations that require QMP not (for example > save/restore). > > Thanks for any reply and sorry for my bad english. > The patch: >>From 1b0221078353870fe530e49de158cae205f9bce5 Mon Sep 17 00:00:00 2001 From: Don Slutz Date: Thu, 4 Jun 2015 17:04:42 -0400 Subject: [PATCH 01/14] monitor: Allow Xen's (broken) usage of asynchronous command interface. commit 65207c59d99f2260c5f1d3b9c491146616a522aa Author: Markus Armbruster Date: Thu Mar 5 14:35:26 2015 +0100 monitor: Drop broken, unused asynchronous command interface Breaks Xen. Add a hack un unbreak it. Xen is only doing synchronous commands, but is including an id. Signed-off-by: Don Slutz --- monitor.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/monitor.c b/monitor.c index c7baa91..e9a0747 100644 --- a/monitor.c +++ b/monitor.c @@ -4955,6 +4955,15 @@ static QDict *qmp_check_input_obj(QObject *input_obj, Error **errp) "arguments", "object"); return NULL; } + } else if (!strcmp(arg_name, "id")) { + /* + * Fixup Xen's usage. Just ignore the "id". See point #5 + * above. This was an attempt at an asynchronous + * command interface. However commit + * 65207c59d99f2260c5f1d3b9c491146616a522aa is + * wrong. Xen does not expect an error when it passes in + * "id":1, so just continue to ignore it. + */ } else { error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name); return NULL; -- 1.7.11.7 fixes things for me -Don Slutz > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [Xen-devel] qemu mainline regression with xen-unstable: unable to start QMP Date: Thu, 04 Jun 2015 17:59:44 -0400 Message-ID: <5570CA50.3080206@Gmail.com> References: <557068F1.1030400@m2r.biz> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <557068F1.1030400@m2r.biz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Fabio Fantoni , "qemu-devel@nongnu.org" , xen-devel , Stefano Stabellini , Anthony PERARD , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 06/04/15 11:04, Fabio Fantoni wrote: > Today after trying xen-unstable build (tested many hours) of some days > ago I tried update qemu to latest development version (from git master > commit 6fa6b312765f698dc81b2c30e7eeb9683804a05b) and seems that there is > a regression: >> xl create /etc/xen/W7.cfg >> Parsing config from /etc/xen/W7.cfg >> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an >> error message from QMP server: QMP input object member 'id' is unexpected >> libxl: error: libxl_qmp.c:715:libxl__qmp_initialize: Failed to connect >> to QMP > This is caused by: commit 65207c59d99f2260c5f1d3b9c491146616a522aa Author: Markus Armbruster Date: Thu Mar 5 14:35:26 2015 +0100 monitor: Drop broken, unused asynchronous command interface > DomU is working but operations that require QMP not (for example > save/restore). > > Thanks for any reply and sorry for my bad english. > The patch: >>From 1b0221078353870fe530e49de158cae205f9bce5 Mon Sep 17 00:00:00 2001 From: Don Slutz Date: Thu, 4 Jun 2015 17:04:42 -0400 Subject: [PATCH 01/14] monitor: Allow Xen's (broken) usage of asynchronous command interface. commit 65207c59d99f2260c5f1d3b9c491146616a522aa Author: Markus Armbruster Date: Thu Mar 5 14:35:26 2015 +0100 monitor: Drop broken, unused asynchronous command interface Breaks Xen. Add a hack un unbreak it. Xen is only doing synchronous commands, but is including an id. Signed-off-by: Don Slutz --- monitor.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/monitor.c b/monitor.c index c7baa91..e9a0747 100644 --- a/monitor.c +++ b/monitor.c @@ -4955,6 +4955,15 @@ static QDict *qmp_check_input_obj(QObject *input_obj, Error **errp) "arguments", "object"); return NULL; } + } else if (!strcmp(arg_name, "id")) { + /* + * Fixup Xen's usage. Just ignore the "id". See point #5 + * above. This was an attempt at an asynchronous + * command interface. However commit + * 65207c59d99f2260c5f1d3b9c491146616a522aa is + * wrong. Xen does not expect an error when it passes in + * "id":1, so just continue to ignore it. + */ } else { error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name); return NULL; -- 1.7.11.7 fixes things for me -Don Slutz > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel