From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35117)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Z0hwE-00024I-Hn
	for qemu-devel@nongnu.org; Thu, 04 Jun 2015 23:04:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Z0hwD-0006P0-KY
	for qemu-devel@nongnu.org; Thu, 04 Jun 2015 23:04:54 -0400
Message-ID: <557111CE.1080009@redhat.com>
Date: Thu, 04 Jun 2015 21:04:46 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1433463642-21840-1-git-send-email-jsnow@redhat.com>
	<1433463642-21840-6-git-send-email-jsnow@redhat.com>
In-Reply-To: <1433463642-21840-6-git-send-email-jsnow@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="WJMs4hjXFvlHLlQq8v76tvBm3l3gnDcxr"
Subject: Re: [Qemu-devel] [PATCH 5/9] qmp: add qmp cmd
	block-dirty-bitmap-copy
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--WJMs4hjXFvlHLlQq8v76tvBm3l3gnDcxr
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 06/04/2015 06:20 PM, John Snow wrote:
> Add the ability to copy one bitmap to a new bitmap.
>=20
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  blockdev.c           | 22 ++++++++++++++++++++++
>  qapi/block-core.json | 16 ++++++++++++++++
>  qmp-commands.hx      | 30 ++++++++++++++++++++++++++++++
>  3 files changed, 68 insertions(+)

[could be merged with 4]


> =20
> +void qmp_block_dirty_bitmap_copy(const char *node, const char *source,=

> +                                 const char *dest, Error **errp)
> +{
> +    AioContext *aio_context;
> +    BlockDriverState *bs;
> +    BdrvDirtyBitmap *bitmap;
> +
> +    if (!dest || dest[0] =3D=3D '\0') {

qapi doesn't allow NULL for a mandatory option, so !dest is currently
dead code.  Of course, someday I'd like to get rid of have_FOO arguments
for pointer types, with NULL possible on optional parameters, but that's
not happening any time soon.

But it's small enough, even if you leave it in, that I don't mind giving:=


Reviewed-by: Eric Blake <eblake@redhat.com>

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--WJMs4hjXFvlHLlQq8v76tvBm3l3gnDcxr
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJVcRHOAAoJEKeha0olJ0NqH2EIAI/UozoYxG7dDEGWqJC19tgU
MAcJiKmXHiqsKWYy5AkKsCL23qeV1noCPRqL/Esynp9Txshi9QZ0FKMKm026asks
pJftzhr70rKlFKGaEkAMg5jEP2QDhA33TSFRrhcCEHYPVQRriMXGaZv99eR/IAKM
+S5Uxu68Pj7JIVXG7bjfs4pwfotX5DE1o34H/H5YVX3DRL3JYLdwisInXY5D014c
YkmVwh+HzVkW4p9rh6zh34f7ynHaUgt92huyqSUdz3PDVK2fOw60eGkGww4S4Hvh
ahG7rmBhZMac5kgYD18yQIOfRDMfA3jHyHrhr4KUWJlv5L+8KkP0C5IczsuTWtw=
=W2/4
-----END PGP SIGNATURE-----

--WJMs4hjXFvlHLlQq8v76tvBm3l3gnDcxr--