Re: [PATCH 3/7] microblaze/PCI: Remove unnecessary struct pci_dev declaration

[Michal Simek <monstr@monstr.eu>]

[-- Attachment #1: Type: text/plain, Size: 1385 bytes --]

On 06/04/2015 11:49 PM, Bjorn Helgaas wrote:
> All users of arch/microblaze/include/asm/pci.h get it by including
> include/linux/pci.h, which in turn includes <asm/pci.h> after it declares
> struct pci_dev.
> 
> The forward declaration here is unnecessary, so remove it.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> CC: Michal Simek <monstr@monstr.eu>
> ---
>  arch/microblaze/include/asm/pci.h |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/microblaze/include/asm/pci.h b/arch/microblaze/include/asm/pci.h
> index 541400d..67224d3 100644
> --- a/arch/microblaze/include/asm/pci.h
> +++ b/arch/microblaze/include/asm/pci.h
> @@ -27,8 +27,6 @@
>  #define PCIBIOS_MIN_IO		0x1000
>  #define PCIBIOS_MIN_MEM		0x10000000
>  
> -struct pci_dev;
> -
>  /* Values for the `which' argument to sys_pciconfig_iobase syscall.  */
>  #define IOBASE_BRIDGE_NUMBER	0
>  #define IOBASE_MEMORY		1
> 

Tested-by: Michal Simek <michal.simek@xilinx.com>

Bjorn: Do you want me to take this via Microblaze tree?

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]