From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0mTV-00064z-ID for qemu-devel@nongnu.org; Fri, 05 Jun 2015 03:55:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0mTS-0004rh-D7 for qemu-devel@nongnu.org; Fri, 05 Jun 2015 03:55:33 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:33470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0mTS-0004rO-7B for qemu-devel@nongnu.org; Fri, 05 Jun 2015 03:55:30 -0400 Received: by padj3 with SMTP id j3so45852323pad.0 for ; Fri, 05 Jun 2015 00:55:29 -0700 (PDT) Message-ID: <557155E8.1020706@ozlabs.ru> Date: Fri, 05 Jun 2015 17:55:20 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1433478358-993-1-git-send-email-bharata@linux.vnet.ibm.com> <1433478358-993-5-git-send-email-bharata@linux.vnet.ibm.com> <55713D2C.8040503@ozlabs.ru> <20150605070630.GB25832@in.ibm.com> In-Reply-To: <20150605070630.GB25832@in.ibm.com> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 4/8] spapr: Reorganize CPU dt generation code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: bharata@linux.vnet.ibm.com Cc: thuth@redhat.com, mdroth@linux.vnet.ibm.com, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, david@gibson.dropbear.id.au On 06/05/2015 05:06 PM, Bharata B Rao wrote: > On Fri, Jun 05, 2015 at 04:09:48PM +1000, Alexey Kardashevskiy wrote: >>> >>> - ret = fdt_setprop(fdt, offset, "ibm,pft-size", >>> - pft_size_prop, sizeof(pft_size_prop)); >> >> You broke formatting here, above 8 lines should not be in the patch. > > You mean above 80 chars ? It is not above 80 chars. The chunk is: + ret = fdt_setprop(fdt, offset, "ibm,pft-size", + pft_size_prop, sizeof(pft_size_prop)); + if (ret < 0) { + return ret; } - ret = fdt_setprop(fdt, offset, "ibm,pft-size", - pft_size_prop, sizeof(pft_size_prop)); pft_size_prop was under "fdt", now it is not, and this is the only change. > >>> + _FDT((fdt_setprop_cell(fdt, offset, "d-cache-block-size", >>> + env->dcache_line_size))); >> >> Wrong indent. > > checkpatch.pl doesn't complain, but should we start the second line > below ( of the first line ? Below "(" plus 1 char right. set expandtab, set tabstop=4, set shiftwidth=4, set cino=:0,(0 - this is what I use for QEMU. -- Alexey