From: Jack Mitchell <ml@communistcode.co.uk>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] alsa-tools: add dependency glib-2.0
Date: Fri, 05 Jun 2015 10:30:51 +0100 [thread overview]
Message-ID: <55716C4B.7070100@communistcode.co.uk> (raw)
In-Reply-To: <5571005A.8020401@windriver.com>
On 05/06/15 02:50, Kang Kai wrote:
> On 2015年06月04日 17:23, Jack Mitchell wrote:
>> On 04/06/15 06:57, Kai Kang wrote:
>>> Add dependency glib-2.0 for alsa-tools. It is required by new added
>>> sub-component hdajacksensetest.
>>>
>>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>>> ---
>>> meta/recipes-multimedia/alsa/alsa-tools_1.0.29.bb | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-multimedia/alsa/alsa-tools_1.0.29.bb
>>> b/meta/recipes-multimedia/alsa/alsa-tools_1.0.29.bb
>>> index 9133012..b5b9cc4 100644
>>> --- a/meta/recipes-multimedia/alsa/alsa-tools_1.0.29.bb
>>> +++ b/meta/recipes-multimedia/alsa/alsa-tools_1.0.29.bb
>>> @@ -3,7 +3,7 @@ HOMEPAGE = "http://www.alsa-project.org"
>>> BUGTRACKER =
>>> "https://bugtrack.alsa-project.org/alsa-bug/login_page.php"
>>> SECTION = "console/utils"
>>> LICENSE = "GPLv2 & LGPLv2+"
>>> -DEPENDS = "alsa-lib ncurses"
>>> +DEPENDS = "alsa-lib ncurses glib-2.0"
>>> LIC_FILES_CHKSUM =
>>> "file://hdsploader/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
>>> file://ld10k1/COPYING.LIB;md5=7fbc338309ac38fefcd64b04bb903e34"
>>
>> It would be nice to put this behind a hdajacksensetest packageconfig
>> if possible.
>
> The hdajacksensetest is just a sub-directory/component not a feature,
> and it can't be built without library glib.
> If make it as a package config, we have to find a way to remove
> hdajacksensetes. I suppose it is not proper to
> add it as a packageconfig.
>
> BTW, the dependency on glib-2.0 for alsa-tools is passed by depending
> on gtk+3 if 'x11' in distro feauture. If without 'x11',
> not such dependency, then build hdajacksensetest fails. So add
> 'glib-2.0' to DEPENDS.
>
> Thanks,
>
Ok, it's just quite a heavy dependancy for a package which is feasible
to be installed on very small systems; as you have proved by glib-2.0
not beiing available in a non-x11 build. In this case I guess the way
round it would be to split out the alsa-tools packages, but that is also
a lot of work. The patch is fine and I don't use alsa-tools so I have no
strong feelings; I just like to keep and eye on and question bloat.
Cheers,
next prev parent reply other threads:[~2015-06-05 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 5:57 [PATCH] alsa-tools: add dependency glib-2.0 Kai Kang
2015-06-04 9:23 ` Jack Mitchell
2015-06-05 1:50 ` Kang Kai
2015-06-05 9:30 ` Jack Mitchell [this message]
2015-06-05 9:34 ` Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55716C4B.7070100@communistcode.co.uk \
--to=ml@communistcode.co.uk \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.