From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0oHN-0007o3-6F for qemu-devel@nongnu.org; Fri, 05 Jun 2015 05:51:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0oHK-00021A-Du for qemu-devel@nongnu.org; Fri, 05 Jun 2015 05:51:09 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:34206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0oHK-00020v-6l for qemu-devel@nongnu.org; Fri, 05 Jun 2015 05:51:06 -0400 Received: by wibut5 with SMTP id ut5so15484147wib.1 for ; Fri, 05 Jun 2015 02:51:04 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <55717104.2080401@redhat.com> Date: Fri, 05 Jun 2015 11:51:00 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20150604220907.29307.43106.malonedeb@gac.canonical.com> <20150604221517.29692.17739.malone@gac.canonical.com> In-Reply-To: <20150604221517.29692.17739.malone@gac.canonical.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Bug 1462131] Re: qemu mainline regression with xen-unstable: unable to start QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bug 1462131 <1462131@bugs.launchpad.net>, qemu-devel@nongnu.org On 05/06/2015 00:15, Don Slutz wrote: > QMP also uses id, but apparently removes it up front before calling into > this function; so another fix would be having xen remove it up front. No, we don't break users. This patch fixes Xen but not virt-test, which relies on ids. It greps the QMP output for an ID in order to find the output of query-commands. Paolo >> > >> > Signed-off-by: Don Slutz >> > --- >> > monitor.c | 9 +++++++++ >> > 1 file changed, 9 insertions(+) >> > >> > diff --git a/monitor.c b/monitor.c >> > index c7baa91..e9a0747 100644 >> > --- a/monitor.c >> > +++ b/monitor.c >> > @@ -4955,6 +4955,15 @@ static QDict *qmp_check_input_obj(QObject >> > *input_obj, Error **errp) >> > "arguments", "object"); >> > return NULL; >> > } >> > + } else if (!strcmp(arg_name, "id")) { >> > + /* >> > + * Fixup Xen's usage. Just ignore the "id". See point #5 >> > + * above. This was an attempt at an asynchronous >> > + * command interface. However commit >> > + * 65207c59d99f2260c5f1d3b9c491146616a522aa is >> > + * wrong. Xen does not expect an error when it passes in >> > + * "id":1, so just continue to ignore it. >> > + */ > The comment is a bit verbose, particularly since 'id' is a > well-established usage pattern in QMP. Also, we don't need to call out > why it changed in the comment here, the commit message is sufficient for > that. >