From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0qfC-0000t5-GA for qemu-devel@nongnu.org; Fri, 05 Jun 2015 08:23:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0qf8-0004a2-C0 for qemu-devel@nongnu.org; Fri, 05 Jun 2015 08:23:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0qY0-0002SO-Db for qemu-devel@nongnu.org; Fri, 05 Jun 2015 08:16:28 -0400 Message-ID: <55719312.80903@redhat.com> Date: Fri, 05 Jun 2015 06:16:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433499756-18720-1-git-send-email-stefanha@redhat.com> <1433499756-18720-5-git-send-email-stefanha@redhat.com> In-Reply-To: <1433499756-18720-5-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MuatHiNucHd7P6Op1WdDiBjs3ibJ5CaQX" Subject: Re: [Qemu-devel] [PULL 4/4] qmp/hmp: add rocker device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Peter Maydell , Scott Feldman , Jiri Pirko This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MuatHiNucHd7P6Op1WdDiBjs3ibJ5CaQX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/05/2015 04:22 AM, Stefan Hajnoczi wrote: > From: Scott Feldman > Add QMP/HMP support for rocker devices. This is mostly for debugging p= urposes > to see inside the device's tables and port configurations. Some exampl= es: >=20 > (qemu) info rocker sw1 > name: sw1 > id: 0x0000013512005452 > ports: 4 >=20 >=20 > [Changed "%-4ld" to "%4" PRIu64 in hmp_rocker_of_dpa_flows() since > flow->hits is uint64_t. This fixes compilation on 32-bit hosts. > --Stefan] >=20 > Signed-off-by: Scott Feldman > Signed-off-by: Jiri Pirko > Message-id: 1432908109-31559-5-git-send-email-sfeldma@gmail.com > Signed-off-by: Stefan Hajnoczi > --- > +++ b/qapi/rocker.json > @@ -0,0 +1,286 @@ > +## > +# @Rocker: > +# > +# Rocker switch information. > +# > +# @name: switch name > +# > +# @id: switch ID > +# > +# @ports: number of front-panel ports > +# > +# Since: 2.4 > +## > +{ 'struct': 'RockerSwitch', > + 'data': { 'name': 'str', 'id': 'uint64', 'ports': 'uint32' } } > + > +## > +# @rocker: This... > +# > +# Return rocker switch information. > +# > +# Returns: @Rocker information > +# > +# Since: 2.4 > +## > +{ 'command': 'query-rocker', =2E..and several other query- commands added in this file, are documented= incorrectly (missing the query- in the comment lead-in). Since this is already at a pull request, it's better to fix it up in a followup patch if there is no other reason to hold up the pull. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MuatHiNucHd7P6Op1WdDiBjs3ibJ5CaQX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVcZMSAAoJEKeha0olJ0NqkRIIAKYT9NkUuNh1DWNs5SPIz1iv xBL+6NPFYCFxwlj5sdRMg4TNuzMoZgFz/3Qb47WHXfMJcvNZyUf/H8Q2s5tL6A/l KZH4OOl2/eU7DP8Fc2G1/ZvcR974jyOzgh/oqOPO9PzPTP7lD825WDXb701vqfuO 60MhD4ytZttxL5gGvtAqjKb9DDHg6sFkD0/CzEGcE+/KyJIWXFEMEOBu3DyoycS6 bmlzwcrScaNzimE+faHtW3InsC/82yMlCBbUp+aLwhUXIj3Md9Vq9HBVjO/0NhwV 7MPGldmOYjOhijQFk+DQRJrIZyethdRv4lCX7Eiu/dCT/L2Z8Yx+pQmH87Is0mY= =bxzJ -----END PGP SIGNATURE----- --MuatHiNucHd7P6Op1WdDiBjs3ibJ5CaQX--