From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 03/22] xen/arm: gic-v3: Fix the distributor region to 64kB Date: Fri, 5 Jun 2015 13:56:47 +0100 Message-ID: <55719C8F.4@citrix.com> References: <1431091783-29090-1-git-send-email-julien.grall@citrix.com> <1431091783-29090-4-git-send-email-julien.grall@citrix.com> <1433506448.7108.242.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z0rBd-0006pP-9C for xen-devel@lists.xenproject.org; Fri, 05 Jun 2015 12:57:25 +0000 In-Reply-To: <1433506448.7108.242.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Julien Grall Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 05/06/15 13:14, Ian Campbell wrote: > On Fri, 2015-05-08 at 14:29 +0100, Julien Grall wrote: >> On GICv3, the default size of the distributor region is 64kB. This >> region can be extended > > But never shrunk, correct? Would a sanity check during parsing be > worthwhile? Yes. See 5.3 in PRD03-GENC-010745 24.0. I can add a reference to it. Well, we trust the device tree value in many place in Xen. If the DT provided by the platform is wrong, Xen won't be the only software in trouble. >> to provide an implementation defined set of >> pages containing additional aliases for MSI. Although, the GICv3 driver >> only access to register within the default distributor region. > > "only accesses registers within". > >> >> Futhermore, our vGIC driver implementation don't support the extended > > "Furthermore" and "doesn't support" > >> distributor. Therefore there is no reason to claim it to DOM0. > > I think I would say "expose" or "map" rather than claim? I think "expose" is the best word as this region is trapped in Xen for emulation. >> Finally drop the field dbase_size which is not useful anymore. >> >> Signed-off-by: Julien Grall > > > With the typoes fixed: > Acked-by: Ian Campbell Thanks, -- Julien Grall