From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <don.slutz@gmail.com>
Subject: Re: [PATCH v11 5/9] xen: Add vmware_port support
Date: Fri, 05 Jun 2015 09:18:28 -0400
Message-ID: <5571A1A4.1000000@Gmail.com>
References: <1432309826-6420-1-git-send-email-dslutz@verizon.com>	<1432309826-6420-6-git-send-email-dslutz@verizon.com>
	<55718D890200007800081379@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55718D890200007800081379@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Don Slutz <dslutz@verizon.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Tim Deegan <tim@xen.org>, xen-devel@lists.xen.org, Eddie Dong <eddie.dong@intel.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jun Nakajima <jun.nakajima@intel.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Ian Jackson <ian.jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 06/05/15 05:52, Jan Beulich wrote:
>>>> On 22.05.15 at 17:50, <dslutz@verizon.com> wrote:
>> @@ -5805,6 +5808,12 @@ static int hvmop_set_param(
>>               break;
>>           if ( a.value > 1 )
>>               rc = -EINVAL;
>> +        /* Prevent nestedhvm with vmport */
>> +        if ( d->arch.hvm_domain.is_vmware_port_enabled )
>> +        {
>> +            rc = -EOPNOTSUPP;
>> +            break;
>> +        }
> Surrounding code avoiding the use of "break" makes the result look
> rather inconsistent. Please move this up immediately after the XSM
> check, or drop the "break".

Will do.

    -Don Slutz

> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel