From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 03/22] xen/arm: gic-v3: Fix the distributor region to 64kB Date: Fri, 5 Jun 2015 15:11:08 +0100 Message-ID: <5571ADFC.1050404@citrix.com> References: <1431091783-29090-1-git-send-email-julien.grall@citrix.com> <1431091783-29090-4-git-send-email-julien.grall@citrix.com> <1433506448.7108.242.camel@citrix.com> <55719C8F.4@citrix.com> <1433510997.7108.306.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z0sLt-0006iE-JB for xen-devel@lists.xenproject.org; Fri, 05 Jun 2015 14:12:05 +0000 In-Reply-To: <1433510997.7108.306.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Julien Grall Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 05/06/15 14:29, Ian Campbell wrote: > On Fri, 2015-06-05 at 13:56 +0100, Julien Grall wrote: >> On 05/06/15 13:14, Ian Campbell wrote: >>> On Fri, 2015-05-08 at 14:29 +0100, Julien Grall wrote: >>>> On GICv3, the default size of the distributor region is 64kB. This >>>> region can be extended >>> >>> But never shrunk, correct? Would a sanity check during parsing be >>> worthwhile? > >> Yes. See 5.3 in PRD03-GENC-010745 24.0. I can add a reference to it. > > Good, thanks. > >> Well, we trust the device tree value in many place in Xen. If the DT >> provided by the platform is wrong, Xen won't be the only software in >> trouble. > > We do warn about other similar things though, as a helpful hint to our > users. (dodgy timer interrupt stuff springs to mind) We don't do any check size in GIC drivers. If we add this one, I would prefer to add all the others one too. But in a separate driver. Regards, -- Julien Grall