All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Guenter Roeck <linux@roeck-us.net>, Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] MIPS: traps: Add missing include file
Date: Fri, 05 Jun 2015 17:35:34 +0300	[thread overview]
Message-ID: <5571B3B6.9090202@cogentembedded.com> (raw)
In-Reply-To: <1433514585-26380-1-git-send-email-linux@roeck-us.net>

Hello.

On 6/5/2015 5:29 PM, Guenter Roeck wrote:

> Commit 05155ddc2617 ("MIPS: get rid of 'kgdb_early_setup' cruft")
> removed the include of linux/kgdb.h from arch/mips/kernel/traps.c.

    Sorry about that. And thanks for beating me to it. :-)

> This results in

> arch/mips/kernel/traps.c: In function 'show_stack':
> arch/mips/kernel/traps.c:204:14: error: 'kgdb_active' undeclared

    The build robot has informed me about that one...

> arch/mips/kernel/traps.c: In function 'do_trap_or_bp':
> arch/mips/kernel/traps.c:877:2: error:
> 		implicit declaration of function 'kgdb_ll_trap'

    ... but not about this one.

> when building mips:allmodconfig.
>
> Fixes: 05155ddc2617 ("MIPS: get rid of 'kgdb_early_setup' cruft")
> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

WBR, Sergei

  reply	other threads:[~2015-06-05 14:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05 14:29 [PATCH -next] MIPS: traps: Add missing include file Guenter Roeck
2015-06-05 14:35 ` Sergei Shtylyov [this message]
2015-06-05 15:03 ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5571B3B6.9090202@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux@roeck-us.net \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.