From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 11/22] xen/arm: gic-hip04: Remove redundant check in hip04gic_init Date: Fri, 5 Jun 2015 16:29:21 +0100 Message-ID: <5571C051.3030508@citrix.com> References: <1431091783-29090-1-git-send-email-julien.grall@citrix.com> <1431091783-29090-12-git-send-email-julien.grall@citrix.com> <1433507096.7108.255.camel@citrix.com> <1433507214.7108.257.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z0ta9-0006aa-8t for xen-devel@lists.xenproject.org; Fri, 05 Jun 2015 15:30:53 +0000 In-Reply-To: <1433507214.7108.257.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Julien Grall Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com, Zoltan Kiss List-Id: xen-devel@lists.xenproject.org On 05/06/15 13:26, Ian Campbell wrote: > On Fri, 2015-06-05 at 13:24 +0100, Ian Campbell wrote: >> On Fri, 2015-05-08 at 14:29 +0100, Julien Grall wrote: >>> There is a global check for page alignment within this function. >>> >>> Signed-off-by: Julien Grall >>> Cc: Zoltan Kiss >> >> Acked-by: Ian Campbell > > Lets make that a blanket Ack for any gic-hop04 patch in this series > where I've already acked a basically equivalent gicv2 patch. > > In fact for the scope of these changes: > xen/arm: *: Remove redundant check in gicv2_init > xen/arm: *: Use SZ_64K rather than our custom value > xen/arm: *: Use SZ_4K rather than PAGE_SIZE > xen/arm: *: Allow the base address to be 0 > > it would be fine to just do them in one "Use SZ_64K in all gic drivers" > type patch. It was easier for me to keep track of the changes made in different driver. Shall I merge them in the next version? Regards, -- Julien Grall