Re: [LTP] [PATCH v2 2/6] lib6/asapi_04.c: Cleanup

[Alexey Kodanev <alexey.kodanev@oracle.com>]

On 02.06.2015 15:21, Zeng Linggang wrote:
> -		for (word = 0; word < 4; ++word)
> -			for (bit = 0; bit < 32; ++bit) {
> -				uint32_t newbit = 1 << bit;
> +	for (word = 0; word < 4; ++word)
> +		for (bit = 0; bit < 32; ++bit) {
> +			uint32_t newbit = 1 << bit;

1 is int here, please change it to unsigned int as follows:

uint32_t newbit = 1U << bit;


>   
> -void *ilistener(void *arg)
> +static void *ilistener(void *arg __attribute__ ((unused)))

LTP has a macro for it, a sort of LTP_ATTR_UNUSED

> -#define MAX(a, b) ((a) >= (b) ? (a) : (b))
> +# define MAX(a, b) ((a) >= (b) ? (a) : (b))

It seems it is not common for LTP coding style to use space there.

> -
>   int TST_TOTAL = PTCOUNT + CSCOUNT;

May be move it closer to CSCOUNT?

Best regards,
Alexey

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list