From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= Subject: Re: [PATCH 49/88] drm/amdgpu: remove AMDGPU_GEM_CREATE_CPU_GTT_UC Date: Sat, 06 Jun 2015 21:09:08 +0200 Message-ID: <55734554.8050900@vodafone.de> References: <1432696827-3752-1-git-send-email-alexander.deucher@amd.com> <1432696827-3752-19-git-send-email-alexander.deucher@amd.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1743802574==" Return-path: Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38]) by gabe.freedesktop.org (Postfix) with ESMTP id D388C6E3DD for ; Sat, 6 Jun 2015 12:09:18 -0700 (PDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by pegasos-out.vodafone.de (Rohrpostix1 Daemon) with ESMTP id 875C426076E for ; Sat, 6 Jun 2015 21:09:16 +0200 (CEST) Received: from pegasos-out.vodafone.de ([127.0.0.1]) by localhost (rohrpostix1.prod.vfnet.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CSeRq+KsnrAJ for ; Sat, 6 Jun 2015 21:09:14 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Oded Gabbay , Alex Deucher , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --===============1743802574== Content-Type: multipart/alternative; boundary="------------010206070201020802070703" This is a multi-part message in MIME format. --------------010206070201020802070703 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 06.06.2015 19:08, Oded Gabbay wrote: > Hi Alex, > I think you have a mistake in this patch. > You renamed AMDGPU_GEM_CREATE_CPU_GTT_WC to > AMDGPU_GEM_CREATE_CPU_GTT_USWC, however, AMDGPU_GEM_CREATE_CPU_GTT_WC > was defined as (1 << 3) and AMDGPU_GEM_CREATE_CPU_GTT_USWC is defined > as (1 << 2) That patch merged AMDGPU_GEM_CREATE_CPU_GTT_WC and AMDGPU_GEM_CREATE_CPU_GTT_UC to AMDGPU_GEM_CREATE_CPU_GTT_USWC. So using 1 << 2 for the new value is perfectly fine. Christian. > > Oded > > On Wed, May 27, 2015 at 6:22 AM Alex Deucher > wrote: > > From: Jammy Zhou > > > This flag isn't used by user mode drivers, remove it to avoid > confusion. And rename GTT_WC to GTT_USWC to make it clear. > > Signed-off-by: Jammy Zhou > > Reviewed-by: Alex Deucher > > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 10 ++-------- > include/uapi/drm/amdgpu_drm.h | 7 ++----- > 2 files changed, 4 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > index f5e17f9..992b7f5 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > @@ -132,10 +132,7 @@ void amdgpu_ttm_placement_from_domain(struct > amdgpu_bo *rbo, u32 domain) > } > > if (domain & AMDGPU_GEM_DOMAIN_GTT) { > - if (rbo->flags & AMDGPU_GEM_CREATE_CPU_GTT_UC) { > - rbo->placements[c].fpfn = 0; > - rbo->placements[c++].flags = > TTM_PL_FLAG_UNCACHED | TTM_PL_FLAG_TT; > - } else if (rbo->flags & > AMDGPU_GEM_CREATE_CPU_GTT_WC) { > + if (rbo->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC) { > rbo->placements[c].fpfn = 0; > rbo->placements[c++].flags = > TTM_PL_FLAG_WC | TTM_PL_FLAG_TT | > TTM_PL_FLAG_UNCACHED; > @@ -146,10 +143,7 @@ void amdgpu_ttm_placement_from_domain(struct > amdgpu_bo *rbo, u32 domain) > } > > if (domain & AMDGPU_GEM_DOMAIN_CPU) { > - if (rbo->flags & AMDGPU_GEM_CREATE_CPU_GTT_UC) { > - rbo->placements[c].fpfn = 0; > - rbo->placements[c++].flags = > TTM_PL_FLAG_UNCACHED | TTM_PL_FLAG_SYSTEM; > - } else if (rbo->flags & > AMDGPU_GEM_CREATE_CPU_GTT_WC) { > + if (rbo->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC) { > rbo->placements[c].fpfn = 0; > rbo->placements[c++].flags = > TTM_PL_FLAG_WC | TTM_PL_FLAG_SYSTEM | > TTM_PL_FLAG_UNCACHED; > diff --git a/include/uapi/drm/amdgpu_drm.h > b/include/uapi/drm/amdgpu_drm.h > index 9e771fb..77bc574 100644 > --- a/include/uapi/drm/amdgpu_drm.h > +++ b/include/uapi/drm/amdgpu_drm.h > @@ -73,15 +73,12 @@ > #define AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED (1 << 0) > /* Flag that CPU access will not work, this VRAM domain is > invisible */ > #define AMDGPU_GEM_CREATE_NO_CPU_ACCESS (1 << 1) > -/* Flag that un-cached attributes should be used for GTT */ > -#define AMDGPU_GEM_CREATE_CPU_GTT_UC (1 << 2) > /* Flag that USWC attributes should be used for GTT */ > -#define AMDGPU_GEM_CREATE_CPU_GTT_WC (1 << 3) > +#define AMDGPU_GEM_CREATE_CPU_GTT_USWC (1 << 2) > > /* Flag mask for GTT domain_flags */ > #define AMDGPU_GEM_CREATE_CPU_GTT_MASK \ > - (AMDGPU_GEM_CREATE_CPU_GTT_WC | \ > - AMDGPU_GEM_CREATE_CPU_GTT_UC | \ > + (AMDGPU_GEM_CREATE_CPU_GTT_USWC | \ > AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED | \ > AMDGPU_GEM_CREATE_NO_CPU_ACCESS) > > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel --------------010206070201020802070703 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 06.06.2015 19:08, Oded Gabbay wrote= :
Hi Alex,
I think you have a mistake in this patch.
You renamed=C2=A0AMDGPU_GEM_CREATE_CPU_GTT_WC to=C2=A0AMDGPU_GEM_CREATE_CPU_GTT_USW= C, however,=C2=A0AMDGPU_GEM_CREATE_CPU_GTT_WC was defined as (1 << 3) and=C2=A0AMDGPU_GEM_CREATE_CPU_GTT_USW= C is defined as (1 << 2)

That patch merged AMDGPU_GEM_CREATE_CPU_GTT_WC and AMDGPU_GEM_CREATE_CPU_GTT_UC to AMDGPU_GEM_CREATE_CPU_GTT_USWC.

So using 1 << 2 for the new value is perfectly fine.

Christian.


Oded

On Wed, May 27, 2015 at 6:22 AM Alex Deucher <= ;alexdeucher@gmail.com> wrote:
From: Jammy Zhou <Jammy.Zh= ou@amd.com>

This flag isn't used by user mode drivers, remove it to avoid confusion. And rename GTT_WC to GTT_USWC to make it clear.

Signed-off-by: Jammy Zhou <Jammy.Zh= ou@amd.com>
Reviewed-by: Alex Deucher <a= lexander.deucher@amd.com>
---
=C2=A0drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 10 ++-------= -
=C2=A0include/uapi/drm/amdgpu_drm.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 |=C2=A0 7 ++-----
=C2=A02 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index f5e17f9..992b7f5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -132,10 +132,7 @@ void amdgpu_ttm_placement_from_domain(struct amdgpu_bo *rbo, u32 domain)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }

=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (domain & AMDGPU_GEM_DOMAIN_= GTT) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (rbo= ->flags & AMDGPU_GEM_CREATE_CPU_GTT_UC) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0rbo->placements[c].fpfn =3D 0;
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0rbo->placements[c++].flags =3D TTM_PL_FLAG_UNCACHED | TTM_PL_FLAG_TT;
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} else = if (rbo->flags & AMDGPU_GEM_CREATE_CPU_GTT_WC) {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (rbo= ->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 rbo->placements[c].fpfn =3D 0;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 rbo->placements[c++].flags =3D TTM_PL_FLAG_WC | TTM_PL_FLAG_TT |
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0TTM_PL_FLAG_UNCACHED;
@@ -146,10 +143,7 @@ void amdgpu_ttm_placement_from_domain(struct amdgpu_bo *rbo, u32 domain)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }

=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (domain & AMDGPU_GEM_DOMAIN_= CPU) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (rbo= ->flags & AMDGPU_GEM_CREATE_CPU_GTT_UC) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0rbo->placements[c].fpfn =3D 0;
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0rbo->placements[c++].flags =3D=C2=A0 TTM_PL_FLAG_UNCACHED | TTM_PL_FLAG_SYSTEM;
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} else = if (rbo->flags & AMDGPU_GEM_CREATE_CPU_GTT_WC) {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (rbo= ->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 rbo->placements[c].fpfn =3D 0;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 rbo->placements[c++].flags =3D TTM_PL_FLAG_WC | TTM_PL_FLAG_SYSTEM |
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0TTM_PL_FLAG_UNCACHED;
diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h
index 9e771fb..77bc574 100644
--- a/include/uapi/drm/amdgpu_drm.h
+++ b/include/uapi/drm/amdgpu_drm.h
@@ -73,15 +73,12 @@
=C2=A0#define AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED=C2=A0 (1 &l= t;< 0)
=C2=A0/* Flag that CPU access will not work, this VRAM domain i= s invisible */
=C2=A0#define AMDGPU_GEM_CREATE_NO_CPU_ACCESS=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (1 << 1)
-/* Flag that un-cached attributes should be used for GTT */ -#define AMDGPU_GEM_CREATE_CPU_GTT_UC=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0(1 << 2)
=C2=A0/* Flag that USWC attributes should be used for GTT */ -#define AMDGPU_GEM_CREATE_CPU_GTT_WC=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0(1 << 3)
+#define AMDGPU_GEM_CREATE_CPU_GTT_USWC=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0(1 << 2)

=C2=A0/* Flag mask for GTT domain_flags */
=C2=A0#define AMDGPU_GEM_CREATE_CPU_GTT_MASK \
-=C2=A0 =C2=A0 =C2=A0 =C2=A0(AMDGPU_GEM_CREATE_CPU_GTT_WC | \ -=C2=A0 =C2=A0 =C2=A0 =C2=A0 AMDGPU_GEM_CREATE_CPU_GTT_UC | \ +=C2=A0 =C2=A0 =C2=A0 =C2=A0(AMDGPU_GEM_CREATE_CPU_GTT_USWC | \=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0AMDGPU_GEM_CREATE_CPU_ACCESS_= REQUIRED | \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0AMDGPU_GEM_CREATE_NO_CPU_ACCE= SS)

--
1.8.3.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listin= fo/dri-devel


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/=
dri-devel

--------------010206070201020802070703-- --===============1743802574== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1743802574==--