From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] staging: rtl8192e: fix some confusing indenting
Date: Sun, 07 Jun 2015 15:49:30 +0000 [thread overview]
Message-ID: <5574680A.7090107@gmail.com> (raw)
In-Reply-To: <20150605092406.GC24871@mwanda>
On 05.06.2015 11:24, Dan Carpenter wrote:
> The indenting here causes a static checker warning:
>
> drivers/staging/rtl8192e/rtllib_rx.c:626 RxReorderIndicatePacket()
> warn: curly braces intended?
>
> The code is actually correct, it's just that these lines were pushed in
> an extra indent level by mistake in 35e33b0468ab ('staging: rtl8192e:
> Fix LONG_LINE warnings').
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index 6977f04..2bef1f6 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -623,9 +623,9 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee,
> else
> pTS->RxIndicateSeq = 4095 -
> (WinSize - (SeqNum + 1)) + 1;
> - netdev_dbg(ieee->dev,
> - "Window Shift! IndicateSeq: %d, NewSeq: %d\n",
> - pTS->RxIndicateSeq, SeqNum);
> + netdev_dbg(ieee->dev,
> + "Window Shift! IndicateSeq: %d, NewSeq: %d\n",
> + pTS->RxIndicateSeq, SeqNum);
> }
>
> /* Indication process.
>
Ouch, Thanks!
I've missed this one.
M.
prev parent reply other threads:[~2015-06-07 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 9:24 [patch] staging: rtl8192e: fix some confusing indenting Dan Carpenter
2015-06-07 15:49 ` Mateusz Kulikowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5574680A.7090107@gmail.com \
--to=mateusz.kulikowski@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.