All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Pavel Fedin <p.fedin@samsung.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Do not fail if id field is present.
Date: Mon, 08 Jun 2015 10:17:13 +0200	[thread overview]
Message-ID: <55754F89.7010206@redhat.com> (raw)
In-Reply-To: <87sia2lixw.fsf@blackfin.pond.sub.org>



On 08/06/2015 10:10, Markus Armbruster wrote:
> > > +        } else if (!strcmp(arg_name, "id")) {
> > > +            /* Ignored, necessary for backwards compatibility */
> > >          } else {
> > >              error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name);
> > >              return NULL;
> > > 
> >
> > Nope, this is not enough to fix virt-test.
> Really?  Details?

It really wants the id in the reply to match the id in the request.

Paolo

  reply	other threads:[~2015-06-08  8:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05 14:17 [Qemu-devel] [PATCH] Do not fail if id field is present Pavel Fedin
2015-06-05 14:32 ` Daniel P. Berrange
2015-06-05 22:10   ` Eric Blake
2015-06-08  8:08     ` Markus Armbruster
2015-06-08  8:24       ` Paolo Bonzini
2015-06-05 14:36 ` Paolo Bonzini
2015-06-08  8:10   ` Markus Armbruster
2015-06-08  8:17     ` Paolo Bonzini [this message]
2015-06-08  8:26       ` Wen Congyang
2015-06-05 15:43 ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55754F89.7010206@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=p.fedin@samsung.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.