From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43215)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1Z1sGT-0006m1-8r
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 04:18:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1Z1sGO-00048R-Qe
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 04:18:37 -0400
Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:53742)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1Z1sGO-00047D-H1
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 04:18:32 -0400
Received: from /spool/local
	by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Mon, 8 Jun 2015 09:18:31 +0100
Message-ID: <55754FD2.2060008@de.ibm.com>
Date: Mon, 08 Jun 2015 10:18:26 +0200
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1433434853-19229-1-git-send-email-peter.maydell@linaro.org>
	<55754C19.8030100@de.ibm.com>
In-Reply-To: <55754C19.8030100@de.ibm.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/4] blockdev: Defer creation of implicit
 PCI devices for IF_VIRTIO drives
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, patches@linaro.org, Alexander Graf <agraf@suse.de>, Markus Armbruster <armbru@redhat.com>, Cornelia Huck <cornelia.huck@de.ibm.com>

Am 08.06.2015 um 10:02 schrieb Christian Borntraeger:
> So I would prefer to not have this workaround and doing 
> 
> index c480f64..7627d57 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -976,17 +976,6 @@ DriveInfo *drive_new(QemuOpts *all_opts, BlockInterfaceType block_default_type)
>          goto fail;
>      }
>  
> -    if (type == IF_VIRTIO && !done_orphan_check
> -        && arch_type == QEMU_ARCH_S390X) {
> -        /* Virtio drives created on the command line get an implicit device
> -         * created for them. For non-s390x command line drives, the creation
> -         * of the implicit device is deferred to drive_check_orphaned. (S390x
> -         * is special-cased purely for backwards compatibility.)
> -         * Drives created via the monitor (hotplugged) do not get the
> -         * magic implicit device created for them.
> -         */
> -        create_implicit_virtio_device(qdict_get_str(bs_opts, "id"), devaddr);
> -    }
>  
>      filename = qemu_opt_get(legacy_opts, "file");
> 
> actually enables the first command line to work as well.
> So lets get rid of the s390 special handling (but I really appreciate that
> you cared about s390)

As a side note, I cannot test this with libvirt right now, as current qemu broke
libvirts capability query
see
https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01806.html
https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01488.html


Christian