From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44778)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1Z1sKJ-0000ET-8n
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 04:22:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1Z1sKF-0006pF-96
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 04:22:35 -0400
Received: from [59.151.112.132] (port=32106 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1Z1sKE-0006j5-1y
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 04:22:30 -0400
Message-ID: <557551AC.4020108@cn.fujitsu.com>
Date: Mon, 8 Jun 2015 16:26:20 +0800
From: Wen Congyang <wency@cn.fujitsu.com>
MIME-Version: 1.0
References: <02aa01d09f9a$5bb198d0$1314ca70$@samsung.com>	<5571B3E6.1030606@redhat.com>	<87sia2lixw.fsf@blackfin.pond.sub.org>
	<55754F89.7010206@redhat.com>
In-Reply-To: <55754F89.7010206@redhat.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Do not fail if id field is present.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Markus Armbruster <armbru@redhat.com>
Cc: Pavel Fedin <p.fedin@samsung.com>, qemu-devel@nongnu.org

On 06/08/2015 04:17 PM, Paolo Bonzini wrote:
> 
> 
> On 08/06/2015 10:10, Markus Armbruster wrote:
>>>> +        } else if (!strcmp(arg_name, "id")) {
>>>> +            /* Ignored, necessary for backwards compatibility */
>>>>          } else {
>>>>              error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name);
>>>>              return NULL;
>>>>
>>>
>>> Nope, this is not enough to fix virt-test.
>> Really?  Details?
> 
> It really wants the id in the reply to match the id in the request.

In handle_qmp_command():
    mon->qmp.id = qdict_get(input, "id");
    qobject_incref(mon->qmp.id);
In monitor_protocol_emitter():
    if (mon->qmp.id) {
        qdict_put_obj(qmp, "id", mon->qmp.id);
        mon->qmp.id = NULL;
    }

So I think there is no problems for virt-test.

Thanks
Wen Congyang

> 
> Paolo
> 
>