From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>,
netdev@vger.kernel.org
Cc: stephen@networkplumber.org
Subject: Re: [PATCH iproute2 resend] Fix changing tunnel remote and local address to any
Date: Mon, 08 Jun 2015 10:51:51 +0200 [thread overview]
Message-ID: <557557A7.5010004@6wind.com> (raw)
In-Reply-To: <20150604120117.GB7119@indiana.gru.redhat.com>
Le 04/06/2015 14:01, Thadeu Lima de Souza Cascardo a écrit :
> If a tunnel is created with a local address, you can't change it to any.
>
> # ip tunnel add tunl1 mode ipip remote 10.16.42.37 local 10.16.42.214 ttl 64
> # ip tunnel show tunl1
> tunl1: ip/ip remote 10.16.42.37 local 10.16.42.214 ttl 64
> # ip tunnel change tunl1 local any
> # echo $?
> 0
> # ip tunnel show tunl1
> tunl1: ip/ip remote 10.16.42.37 local 10.16.42.214 ttl 64
>
> It happens that parse_args zeroes ip_tunnel_parm, and when creating the
> tunnel, it is OK to leave it as is if the address is any. However, when
> changing the tunnel, the current parameters will be read from
> ip_tunnel_parm, and local and remote address won't be zeroes anymore, so
> it needs to be explicitly set to any.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
next prev parent reply other threads:[~2015-06-08 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 12:01 [PATCH iproute2 resend] Fix changing tunnel remote and local address to any Thadeu Lima de Souza Cascardo
2015-06-08 8:51 ` Nicolas Dichtel [this message]
2015-06-25 12:46 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557557A7.5010004@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=cascardo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.