All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: davinci_emac: don't teardown inactive rx channel
Date: Mon, 08 Jun 2015 11:05:15 +0200	[thread overview]
Message-ID: <55755ACB.20503@myspectrum.nl> (raw)
In-Reply-To: <1433691038-21078-1-git-send-email-jeroen@myspectrum.nl>

+cc (forget them somehow)

On 07-06-15 17:30, Jeroen Hofstee wrote:
> Tearing down an unitialized rx channel causes a pending address hole
> event to be queued. When booting linux it will report this pending
> as something like "Address Hole seen by USB_OTG  at address 57fff584",
> since u-boot did not handled this interrupt. Prevent that by not
> tearing down the rx channel, when not receiving.
>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> ---
> To replicate this:
>   - ROMcode must not use the emac
>   - U-Boot must use the emac
>   - only on cold start
> ---
>   drivers/net/davinci_emac.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
> index 427ad3e..0444795 100644
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -598,7 +598,8 @@ static void davinci_eth_close(struct eth_device *dev)
>   	debug_emac("+ emac_close\n");
>   
>   	davinci_eth_ch_teardown(EMAC_CH_TX);	/* TX Channel teardown */
> -	davinci_eth_ch_teardown(EMAC_CH_RX);	/* RX Channel teardown */
> +	if (readl(&adap_emac->RXCONTROL) & 1)
> +		davinci_eth_ch_teardown(EMAC_CH_RX); /* RX Channel teardown */
>   
>   	/* Reset EMAC module and disable interrupts in wrapper */
>   	writel(1, &adap_emac->SOFTRESET);

  reply	other threads:[~2015-06-08  9:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-07 15:30 [U-Boot] [PATCH] net: davinci_emac: don't teardown inactive rx channel Jeroen Hofstee
2015-06-08  9:05 ` Jeroen Hofstee [this message]
2015-06-10 14:24 ` Joe Hershberger
2015-06-11  5:51   ` Tony Lindgren
2015-06-11 14:28     ` Joe Hershberger
2015-08-12 19:26 ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55755ACB.20503@myspectrum.nl \
    --to=jeroen@myspectrum.nl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.