From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb2-smtp-cloud2.xs4all.net ([194.109.24.25]:37689 "EHLO lb2-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752635AbbFHJI4 (ORCPT ); Mon, 8 Jun 2015 05:08:56 -0400 Message-ID: <55755BA2.4060805@xs4all.nl> Date: Mon, 08 Jun 2015 11:08:50 +0200 From: Hans Verkuil MIME-Version: 1.0 To: Antti Palosaari , linux-media@vger.kernel.org Subject: Re: [PATCH 3/9] DocBook: document tuner RF gain control References: <1433592188-31748-1-git-send-email-crope@iki.fi> <1433592188-31748-3-git-send-email-crope@iki.fi> In-Reply-To: <1433592188-31748-3-git-send-email-crope@iki.fi> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Antti, Some typos: On 06/06/2015 02:03 PM, Antti Palosaari wrote: > Add brief description for tuner RF gain control. > > Cc: Hans Verkuil > Signed-off-by: Antti Palosaari > --- > Documentation/DocBook/media/v4l/compat.xml | 4 ++++ > Documentation/DocBook/media/v4l/controls.xml | 19 +++++++++++++++++++ > Documentation/DocBook/media/v4l/v4l2.xml | 1 + > 3 files changed, 24 insertions(+) > > diff --git a/Documentation/DocBook/media/v4l/compat.xml b/Documentation/DocBook/media/v4l/compat.xml > index f56faf5..e8f28bf 100644 > --- a/Documentation/DocBook/media/v4l/compat.xml > +++ b/Documentation/DocBook/media/v4l/compat.xml > @@ -2600,6 +2600,10 @@ and &v4l2-mbus-framefmt;. > V4L2_TUNER_ADC is deprecated now. > > > + > + Added V4L2_CID_RF_TUNER_RF_GAIN_AUTO and > +V4L2_CID_RF_TUNER_RF_GAIN RF Tuner controls. > + > > > > diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml > index 6e1667b..44f7a3a 100644 > --- a/Documentation/DocBook/media/v4l/controls.xml > +++ b/Documentation/DocBook/media/v4l/controls.xml > @@ -5397,6 +5397,13 @@ fulfill desired bandwidth requirement. Used when V4L2_CID_RF_TUNER_BANDWIDTH_AUT > set. Unit is in Hz. The range and step are driver-specific. > > > + V4L2_CID_RF_TUNER_RF_GAIN_AUTO  > + boolean > + > + > + Enables/disables RF amplifier automatic gain control (AGC) > + > + > V4L2_CID_RF_TUNER_LNA_GAIN_AUTO  > boolean > > @@ -5418,6 +5425,18 @@ set. Unit is in Hz. The range and step are driver-specific. > Enables/disables IF automatic gain control (AGC) > > > + V4L2_CID_RF_TUNER_RF_GAIN  > + integer > + > + > + RF amplifier is very first amplifier on > +the receiver signal path, just right after antenna input. Difference between > +LNA gain and RF gain on this document and context is that LNA gain is integrated > +to tuner chip whilst RF gain is separate chip. There may be both, RF and LNA > +gain control, on same device. Used when V4L2_CID_RF_TUNER_RF_GAIN_AUTO is not set. > +The range and step are driver-specific. > + The RF amplifier is the very first amplifier on the receiver signal path, just right after the antenna input. The difference between the LNA gain and the RF gain in this document is that the LNA gain is integrated in the tuner chip while the RF gain is a separate chip. There may be both RF and LNA gain controls in the same device. Used when V4L2_CID_RF_TUNER_RF_GAIN_AUTO is not set. The range and step are driver-specific. > + > V4L2_CID_RF_TUNER_LNA_GAIN  This control should refer to the RF_TUNER_RF_GAIN to help understand the relationship between the two. > integer > > diff --git a/Documentation/DocBook/media/v4l/v4l2.xml b/Documentation/DocBook/media/v4l/v4l2.xml > index c9eedc1..b94d381 100644 > --- a/Documentation/DocBook/media/v4l/v4l2.xml > +++ b/Documentation/DocBook/media/v4l/v4l2.xml > @@ -156,6 +156,7 @@ applications. --> > 2015-05-26 > ap > Renamed V4L2_TUNER_ADC to V4L2_TUNER_SDR. > +Added V4L2_CID_RF_TUNER_RF_GAIN_AUTO and V4L2_CID_RF_TUNER_RF_GAIN controls. > > > > Regards, Hans