All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Antti Palosaari <crope@iki.fi>, linux-media@vger.kernel.org
Subject: Re: [PATCH 9/9] hackrf: do not set human readable name for formats
Date: Mon, 08 Jun 2015 11:20:30 +0200	[thread overview]
Message-ID: <55755E5E.60104@xs4all.nl> (raw)
In-Reply-To: <1433592188-31748-9-git-send-email-crope@iki.fi>

On 06/06/2015 02:03 PM, Antti Palosaari wrote:
> Format names are set by core nowadays. Remove name from driver.
> 
> Signed-off-by: Antti Palosaari <crope@iki.fi>

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

Regards,

	Hans

> ---
>  drivers/media/usb/hackrf/hackrf.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/media/usb/hackrf/hackrf.c b/drivers/media/usb/hackrf/hackrf.c
> index 6ad6937..1f9483d 100644
> --- a/drivers/media/usb/hackrf/hackrf.c
> +++ b/drivers/media/usb/hackrf/hackrf.c
> @@ -69,7 +69,6 @@ static const struct v4l2_frequency_band bands_rx_tx[] = {
>  
>  /* stream formats */
>  struct hackrf_format {
> -	char	*name;
>  	u32	pixelformat;
>  	u32	buffersize;
>  };
> @@ -77,7 +76,6 @@ struct hackrf_format {
>  /* format descriptions for capture and preview */
>  static struct hackrf_format formats[] = {
>  	{
> -		.name		= "Complex S8",
>  		.pixelformat	= V4L2_SDR_FMT_CS8,
>  		.buffersize	= BULK_BUFFER_SIZE,
>  	},
> @@ -977,7 +975,6 @@ static int hackrf_enum_fmt_sdr_cap(struct file *file, void *priv,
>  	if (f->index >= NUM_FORMATS)
>  		return -EINVAL;
>  
> -	strlcpy(f->description, formats[f->index].name, sizeof(f->description));
>  	f->pixelformat = formats[f->index].pixelformat;
>  
>  	return 0;
> 


  reply	other threads:[~2015-06-08  9:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-06 12:03 [PATCH 1/9] v4l2: rename V4L2_TUNER_ADC to V4L2_TUNER_SDR Antti Palosaari
2015-06-06 12:03 ` [PATCH 2/9] v4l2: add RF gain control Antti Palosaari
2015-06-08  9:03   ` Hans Verkuil
2015-07-16  7:13     ` Antti Palosaari
2015-06-06 12:03 ` [PATCH 3/9] DocBook: document tuner " Antti Palosaari
2015-06-08  9:08   ` Hans Verkuil
2015-06-06 12:03 ` [PATCH 4/9] v4l2: add support for SDR transmitter Antti Palosaari
2015-06-08  9:10   ` Hans Verkuil
2015-06-06 12:03 ` [PATCH 5/9] DocBook: document " Antti Palosaari
2015-06-08  9:12   ` Hans Verkuil
2015-06-06 12:03 ` [PATCH 6/9] hackrf: add control for RF amplifier Antti Palosaari
2015-06-06 12:03 ` [PATCH 7/9] hackrf: switch to single function which configures everything Antti Palosaari
2015-06-06 12:03 ` [PATCH 8/9] hackrf: add support for transmitter Antti Palosaari
2015-06-08  9:26   ` Hans Verkuil
2015-07-16  7:09     ` Antti Palosaari
2015-06-06 12:03 ` [PATCH 9/9] hackrf: do not set human readable name for formats Antti Palosaari
2015-06-08  9:20   ` Hans Verkuil [this message]
2015-06-08  8:56 ` [PATCH 1/9] v4l2: rename V4L2_TUNER_ADC to V4L2_TUNER_SDR Hans Verkuil
2015-06-10 13:31   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55755E5E.60104@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=crope@iki.fi \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.