From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Z1ub4-0007Nl-16 for mharc-qemu-trivial@gnu.org; Mon, 08 Jun 2015 06:48:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1uaz-0007GL-Bs for qemu-trivial@nongnu.org; Mon, 08 Jun 2015 06:47:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1uay-0007cl-Ct for qemu-trivial@nongnu.org; Mon, 08 Jun 2015 06:47:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1uav-0007aE-W8; Mon, 08 Jun 2015 06:47:54 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 8FB2A9176E; Mon, 8 Jun 2015 10:47:53 +0000 (UTC) Received: from [10.36.112.50] (ovpn-112-50.ams2.redhat.com [10.36.112.50]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t58AlnFX003198 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 8 Jun 2015 06:47:51 -0400 Message-ID: <557572D5.3050103@redhat.com> Date: Mon, 08 Jun 2015 12:47:49 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Peter Crosthwaite , qemu-devel@nongnu.org References: <1433714349-7262-1-git-send-email-crosthwaite.peter@gmail.com> In-Reply-To: <1433714349-7262-1-git-send-email-crosthwaite.peter@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: qemu-trivial@nongnu.org, Peter Crosthwaite Subject: Re: [Qemu-trivial] [PATCH v2] memory_mapping: Rework cpu related includes X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jun 2015 10:47:58 -0000 On 07/06/2015 23:59, Peter Crosthwaite wrote: > This makes it more consistent with all other core code files, which > either just rely on qemu-common.h inclusion or precede cpu.h with > qemu-common.h. > > cpu-all.h should not be included in addition to cpu.h. Remove it. > > Signed-off-by: Peter Crosthwaite > --- > changed since v1: > Leave in cpu.h include > > Picked up by my multi arch WIP where target-multi/cpu.h cant handle > random core code inclusion without preceeded qemu-common.h. I guess > this is the only one in tree? > --- > memory_mapping.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/memory_mapping.c b/memory_mapping.c > index 7b69801..36d6b26 100644 > --- a/memory_mapping.c > +++ b/memory_mapping.c > @@ -13,8 +13,8 @@ > > #include > > +#include "qemu-common.h" > #include "cpu.h" > -#include "exec/cpu-all.h" > #include "sysemu/memory_mapping.h" > #include "exec/memory.h" > #include "exec/address-spaces.h" > Acked-by: Paolo Bonzini About to leave on vacation, so someone else will have to pick it up. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1uax-0007DU-E8 for qemu-devel@nongnu.org; Mon, 08 Jun 2015 06:47:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1uaw-0007aM-4f for qemu-devel@nongnu.org; Mon, 08 Jun 2015 06:47:55 -0400 Message-ID: <557572D5.3050103@redhat.com> Date: Mon, 08 Jun 2015 12:47:49 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1433714349-7262-1-git-send-email-crosthwaite.peter@gmail.com> In-Reply-To: <1433714349-7262-1-git-send-email-crosthwaite.peter@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Peter Crosthwaite On 07/06/2015 23:59, Peter Crosthwaite wrote: > This makes it more consistent with all other core code files, which > either just rely on qemu-common.h inclusion or precede cpu.h with > qemu-common.h. > > cpu-all.h should not be included in addition to cpu.h. Remove it. > > Signed-off-by: Peter Crosthwaite > --- > changed since v1: > Leave in cpu.h include > > Picked up by my multi arch WIP where target-multi/cpu.h cant handle > random core code inclusion without preceeded qemu-common.h. I guess > this is the only one in tree? > --- > memory_mapping.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/memory_mapping.c b/memory_mapping.c > index 7b69801..36d6b26 100644 > --- a/memory_mapping.c > +++ b/memory_mapping.c > @@ -13,8 +13,8 @@ > > #include > > +#include "qemu-common.h" > #include "cpu.h" > -#include "exec/cpu-all.h" > #include "sysemu/memory_mapping.h" > #include "exec/memory.h" > #include "exec/address-spaces.h" > Acked-by: Paolo Bonzini About to leave on vacation, so someone else will have to pick it up. Paolo