All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Bananapi: Fix ethernet device initialization
Date: Mon, 08 Jun 2015 15:23:33 +0200	[thread overview]
Message-ID: <55759755.3080709@redhat.com> (raw)
In-Reply-To: <1433683536-48879-1-git-send-email-maxin.john@enea.com>

Hi Maxin,

On 07-06-15 15:25, Maxin B. John wrote:
> Ethernet device initialization fails with the following message:
> Net:   PH: dir_output: error: gpio PH23 not reserved
> Phy 1 not found
> PHY reset timed out
> eth0: ethernet at 01c50000
>
> Tested on Banana Pi board.
>
> Signed-off-by: Maxin B. John <maxin.john@enea.com>

Thanks, I actually wrote exactly the same patch myself yesterday, and that
just got acked by Ian today. I'll make sure to get the fix upstream
soonish.

Regards,

Hans


> ---
>   arch/arm/cpu/armv7/sunxi/board.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/cpu/armv7/sunxi/board.c b/arch/arm/cpu/armv7/sunxi/board.c
> index a82c8b9..4b2494e 100644
> --- a/arch/arm/cpu/armv7/sunxi/board.c
> +++ b/arch/arm/cpu/armv7/sunxi/board.c
> @@ -223,6 +223,7 @@ int cpu_eth_init(bd_t *bis)
>   	__maybe_unused int rc;
>
>   #ifdef CONFIG_MACPWR
> +	gpio_request(CONFIG_MACPWR, "macpwr");
>   	gpio_direction_output(CONFIG_MACPWR, 1);
>   	mdelay(200);
>   #endif
>

      reply	other threads:[~2015-06-08 13:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-07 13:25 [U-Boot] [PATCH v2] Bananapi: Fix ethernet device initialization Maxin B. John
2015-06-08 13:23 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55759755.3080709@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.