Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

[Paolo Bonzini <pbonzini@redhat.com>]

On 08/06/2015 15:42, Gal Hammer wrote:
> On 03/06/2015 19:37, Paolo Bonzini wrote:
>>
>> Since Michael said he'd merge this version, there's just one thing I
>> would change.  You can access the region only one byte at a time, and
>> let the memory core fix endianness here:
> 
> I've applied the change offered below. Thanks.
> 
> There are two unanswered questions:
> 
> 1. You wrote that I should not use the memory_region_init_io() function.
> Should I use memory_region_init_ram() instead?

This is related to the uncached vs. cached memory discussion.  Michael
agreed that it's okay to do it this way.

> 2. Is it possible to create a sysbus device using the "-device" command
> line argument? I vaguely recall that it is not possible to do it and
> that's the reason that I specifically add the device in the pc init.

It's now possible, but it is somewhat complicated.  I think it's simpler
to initialize this unconditionally and hide it (via ACPI _STA) if the
vmgenid is all zeros.

Paolo