Re: xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c

[Fabio Fantoni <fabio.fantoni@m2r.biz>]

Il 08/06/2015 15:30, Wei Liu ha scritto:
> On Mon, Jun 08, 2015 at 02:36:09PM +0200, Fabio Fantoni wrote:
>> Il 08/06/2015 13:28, Wei Liu ha scritto:
>>> On Mon, Jun 08, 2015 at 01:25:05PM +0200, Fabio Fantoni wrote:
>>>> I saw that config/Paths.mk contains:
>>>> XEN_DUMP_DIR             := /var/lib/xen/dump
>>>>
>>>> But build fails with:
>>>>> xl_cmdimpl.c: In function âhandle_domain_deathâ:
>>>>> xl_cmdimpl.c:2330:33: error: âXEN_DUMP_DIRâ undeclared (first use in this
>>>>> function)
>>>>> xl_cmdimpl.c:2330:33: note: each undeclared identifier is reported only
>>>>> once for each function it appears in
>>>>> xl_cmdimpl.c:2330:46: error: expected â)â before string constant
>>>> With a fast look in code I not found the right cause.
>>>>
>>>>
>>>> Thanks for any reply and sorry for my bad english.
>>> Our testing system doesn't complain about this.
>>>
>>> Maybe you have some stale files lying around? Try make distclean then
>>> make again?
>>>
>>> Wei.
>> Thanks for your reply.
>>
>> I add some my patches not related:
>> https://github.com/Fantu/Xen/tree/rebase/m2r-staging all already tested for
>> at least some days.
>>
>> I tried another clean build without my patches (git reset --hard ... git
>> clean -f -d -x) but still fails.
>>
>> I did this operations:
>> ./configure --prefix=/usr --disable-blktap1 --disable-qemu-traditional
>> --disable-rombios --with-system-seabios=/usr/share/seabios/bios-256k.bin
>> --with-extra-qemuu-configure-args="--enable-spice --enable-usb-redir"
>> --disable-blktap2 --enable-ovmf --with-system-ovmf=/usr/share/ovmf/OVMF.fd
>> make debball
> Have you checked if libxl/_paths.h is generated?
>
> I don't think I spot anything suspicious in commit log and your build
> rune.
>
> Wei.

I checked tools/libxl/_paths.h, generated with many lines but 
XEN_DUMP_DIR is missed.
> #define SBINDIR ""
> #define BINDIR ""
> #define LIBEXEC "/usr/lib/xen"
> #define LIBEXEC_BIN "/usr/lib/xen/bin"
> #define LIBDIR ""
> #define SHAREDIR "/usr/share"
> #define XENFIRMWAREDIR "/usr/lib/xen/boot"
> #define XEN_CONFIG_DIR "/etc/xen"
> #define XEN_SCRIPT_DIR "/etc/xen/scripts"
> #define XEN_LOCK_DIR "/var/lock"
> #define XEN_RUN_DIR "/var/run/xen"
> #define XEN_PAGING_DIR "/var/lib/xen/xenpaging"
config/Paths.mk instead contain it correctly.
I checked the commit 
http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=bf36d0792032a0245e4a17a64c8b9eb9e056f282 
but not add something about libxl/_paths.h and in it there aren't all 
path present in config.
I suppose that something is missed or there inexpected case that cause 
partial libxl/_paths.h generation (seems more probable the first case).