Re: [PATCH 2/3] slcand: add option -p<file> to write pid to a file.

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1428 bytes --]

On 06/08/2015 03:43 PM, Armin Burchardt wrote:
> Hi Marc,
> 
>> I think "/run/slcand/<IFACE>" would fit better into modern file system
>> layout. What about having a default for the pid file path?
> 
> I would not expect a daemon to accept a filename (or only parts of it) without

Me neither. I was thinking that "-p" without a path would generate a
pidfile in "/run/slcand/<IFACE>"

> a full path. The /etc/init.d/skeleton of Debian wheezy uses /var/run/$NAME.pid

wheezy (a.k.a. old-old-stable)? Ist that still alive? :D

> (for start-stop-daemon's --pidfile option).
> Do we know enough about the filesystem layout of existing (embedded)  
> systems to define
> a useful default?

systemd uses "/run/<daemon>.pid" or "/run/<daemon>/<foo>.pid"

>> Does it make sense to open in exclusive mode?
> 
> If another daemon is started with the same pidfile we would have to give
> up if the file already exists to take advantage of that. Is it  
> expected of a daemon
> using a pidfile to exit with an error or should it just overwrite an  
> existing file?

Right....probably not worth the trouble, keep it as is.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]