From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c Date: Mon, 8 Jun 2015 14:55:49 +0100 Message-ID: <55759EE5.8020205@citrix.com> References: <55757B91.90102@m2r.biz> <20150608112850.GB29102@zion.uk.xensource.com> <55758C39.4030606@m2r.biz> <20150608133027.GD29102@zion.uk.xensource.com> <55759D64.20800@m2r.biz> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <55759D64.20800@m2r.biz> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Fabio Fantoni , Wei Liu Cc: Olaf Hering , xen-devel , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 08/06/15 14:49, Fabio Fantoni wrote: > Il 08/06/2015 15:30, Wei Liu ha scritto: >> On Mon, Jun 08, 2015 at 02:36:09PM +0200, Fabio Fantoni wrote: >>> Il 08/06/2015 13:28, Wei Liu ha scritto: >>>> On Mon, Jun 08, 2015 at 01:25:05PM +0200, Fabio Fantoni wrote: >>>>> I saw that config/Paths.mk contains: >>>>> XEN_DUMP_DIR :=3D /var/lib/xen/dump >>>>> >>>>> But build fails with: >>>>>> xl_cmdimpl.c: In function =E2handle_domain_death=E2: >>>>>> xl_cmdimpl.c:2330:33: error: =E2XEN_DUMP_DIR=E2 undeclared (first use >>>>>> in this >>>>>> function) >>>>>> xl_cmdimpl.c:2330:33: note: each undeclared identifier is >>>>>> reported only >>>>>> once for each function it appears in >>>>>> xl_cmdimpl.c:2330:46: error: expected =E2)=E2 before string constant >>>>> With a fast look in code I not found the right cause. >>>>> >>>>> >>>>> Thanks for any reply and sorry for my bad english. >>>> Our testing system doesn't complain about this. >>>> >>>> Maybe you have some stale files lying around? Try make distclean then >>>> make again? >>>> >>>> Wei. >>> Thanks for your reply. >>> >>> I add some my patches not related: >>> https://github.com/Fantu/Xen/tree/rebase/m2r-staging all already >>> tested for >>> at least some days. >>> >>> I tried another clean build without my patches (git reset --hard ... >>> git >>> clean -f -d -x) but still fails. >>> >>> I did this operations: >>> ./configure --prefix=3D/usr --disable-blktap1 --disable-qemu-traditional >>> --disable-rombios >>> --with-system-seabios=3D/usr/share/seabios/bios-256k.bin >>> --with-extra-qemuu-configure-args=3D"--enable-spice --enable-usb-redir" >>> --disable-blktap2 --enable-ovmf >>> --with-system-ovmf=3D/usr/share/ovmf/OVMF.fd >>> make debball >> Have you checked if libxl/_paths.h is generated? >> >> I don't think I spot anything suspicious in commit log and your build >> rune. >> >> Wei. > > I checked tools/libxl/_paths.h, generated with many lines but > XEN_DUMP_DIR is missed. >> #define SBINDIR "" >> #define BINDIR "" >> #define LIBEXEC "/usr/lib/xen" >> #define LIBEXEC_BIN "/usr/lib/xen/bin" >> #define LIBDIR "" >> #define SHAREDIR "/usr/share" >> #define XENFIRMWAREDIR "/usr/lib/xen/boot" >> #define XEN_CONFIG_DIR "/etc/xen" >> #define XEN_SCRIPT_DIR "/etc/xen/scripts" >> #define XEN_LOCK_DIR "/var/lock" >> #define XEN_RUN_DIR "/var/run/xen" >> #define XEN_PAGING_DIR "/var/lib/xen/xenpaging" > config/Paths.mk instead contain it correctly. > I checked the commit > http://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dcommitdiff;h=3Dbf36d079203= 2a0245e4a17a64c8b9eb9e056f282 > but not add something about libxl/_paths.h and in it there aren't all > path present in config. > I suppose that something is missed or there inexpected case that cause > partial libxl/_paths.h generation (seems more probable the first case). On staging, you generally have to re-./configure and `make clean` regularly. In particular, there was http://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dcommitdiff;h=3Dbf36d0792032a= 0245e4a17a64c8b9eb9e056f282 recently which altered XEN_DUMP_DIR handling. ~Andrew