Re: [Qemu-devel] [PATCH 1/1] monitor: Fix QMP ABI breakage around "id"

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]

On 06/08/2015 02:44 AM, Markus Armbruster wrote:
> Commit 65207c5 accidentally dropped a line of code we need along with
> a comment that became wrong then.  This made QMP reject "id":
> 
>     {"execute": "system_reset", "id": "1"}
>     {"error": {"class": "GenericError", "desc": "QMP input object member 'id' is unexpected"}}
> 
> Put the lost line right back, so QMP again accepts and returns "id",
> as promised by the ABI:
> 
>     {"execute": "system_reset", "id": "1"}
>     {"return": {}, "id": "1"}
> 
> Reported-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Don Slutz <dslutz@verizon.com>
> Tested-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
> Tested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Double S-o-b by Markus is odd.  But it's already landed in master, I'm
too late for fixing it :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]