From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>, Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Jeff Cody <jcody@redhat.com>,
qemu-stable@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
jsnow@redhat.com, wangxiaolong@ucloud.cn
Subject: Re: [Qemu-devel] [PATCH v7 2/8] qmp: Add optional bool "unmap" to drive-mirror
Date: Mon, 08 Jun 2015 16:54:49 +0200 [thread overview]
Message-ID: <5575ACB9.4030503@redhat.com> (raw)
In-Reply-To: <5575ABF7.50306@redhat.com>
On 08/06/2015 16:51, Eric Blake wrote:
>> > +# @unmap: #optional Whether to try to unmap target sectors where source has
>> > +# only zero. If true, and target unallocated sectors will read as zero,
>> > +# target image sectors will be unmapped; otherwise, zeroes will be
>> > +# written. Both will result in identical contents.
>> > +# Default is true. (Since 2.4)
>> > #
> Per the other thread on adding 'detect-zeroes', should we instead be
> using an enum here that describes one of several behaviors without an
> explosion into multiple knobs?
See my answer there. :)
Paolo
next prev parent reply other threads:[~2015-06-08 14:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 5:56 [Qemu-devel] [PATCH v7 0/8] block: Mirror discarded sectors Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 1/8] block: Add bdrv_get_block_status_above Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 2/8] qmp: Add optional bool "unmap" to drive-mirror Fam Zheng
2015-06-08 14:51 ` Eric Blake
2015-06-08 14:54 ` Paolo Bonzini [this message]
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 3/8] mirror: Do zero write on target if sectors not allocated Fam Zheng
2015-11-04 18:35 ` Kevin Wolf
2015-11-05 5:42 ` Fam Zheng
2015-11-05 9:55 ` Kevin Wolf
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 4/8] block: Fix dirty bitmap in bdrv_co_discard Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 5/8] block: Remove bdrv_reset_dirty Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 6/8] qemu-iotests: Make block job methods common Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 7/8] qemu-iotests: Add test case for mirror with unmap Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 8/8] iotests: Use event_wait in wait_ready Fam Zheng
2015-06-08 13:02 ` [Qemu-devel] [PATCH v7 0/8] block: Mirror discarded sectors Stefan Hajnoczi
2015-06-11 8:29 ` Fam Zheng
2015-06-24 9:08 ` [Qemu-devel] [Qemu-stable] " Fam Zheng
2015-06-24 17:01 ` Paolo Bonzini
2015-06-25 1:02 ` Fam Zheng
2015-06-25 10:45 ` Fam Zheng
2015-06-26 13:36 ` Alexandre DERUMIER
2015-06-26 13:58 ` Alexandre DERUMIER
2015-06-29 1:03 ` Fam Zheng
2015-06-26 13:19 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5575ACB9.4030503@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wangxiaolong@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.