From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57878)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Z1zM7-0001tx-D2
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 11:52:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Z1zM3-0002dU-D9
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 11:52:55 -0400
Received: from v220110690675601.yourvserver.net ([37.221.199.173]:50149)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Z1zM3-0002aO-0c
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 11:52:51 -0400
Message-ID: <5575BA4E.1070908@weilnetz.de>
Date: Mon, 08 Jun 2015 17:52:46 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <CAJSP0QXS9PhW+FXvv__L9B87bUqPmy_KsRTU951Uy10zw7gtvw@mail.gmail.com>
	<5571D9FD.2030900@weilnetz.de>
	<20150608092117.GD30104@stefanha-thinkpad.redhat.com>
In-Reply-To: <20150608092117.GD30104@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Redundant redeclaration of 'gmtime_r' with mingw64
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

Am 08.06.2015 um 11:21 schrieb Stefan Hajnoczi:
> On Fri, Jun 05, 2015 at 07:18:53PM +0200, Stefan Weil wrote:
>>
>> The version provided by Debian Jessie (mingw-w64 3.2.0)
>> still uses macros to implement those functions - that's why
>> I don't see that compiler warnings.
>>
>> I'd prefer a solution which conditionally includes the QEMU
>> declaration (include/sysemu/os-win32.h) and the implementation
>> (util/oslib-win32.c), either depending on the mingw-w64 version
>> or on the result of a configuration check done while running
>> configure.
> Does that mean you want:
>
> 1. gmtime() is a macro - use QEMU implementation
> 2. gmtime() is a function - use mingw function

= declared via time.h and implemented in a standard library.

> 3. gmtime() is undefined - use QEMU implementation
>
> ?

Yes, exactly.