atombios_crtc.c - make error messages distinguishable "unable to allocate a PPLL\n"

From: James Feeney <james@nurealm.net>
To: "Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Cc: dri-devel@lists.freedesktop.org
Subject: atombios_crtc.c - make error messages distinguishable "unable to allocate a PPLL\n"
Date: Mon, 08 Jun 2015 10:26:55 -0600	[thread overview]
Message-ID: <5575C24F.7040406@nurealm.net> (raw)

atombios_crtc.c

In multi-display configurations, especially with three or more displays,
PLL/clock source allocations can fail when there are more crtc's than PLLs.
When attempting to debug these PLL allocation failures in the source code, the
error message displayed in the log, DRM_ERROR("unable to allocate a PPLL\n");,
is not useful because the exact same error message is used for _five_ different
error states/code paths.

These different error states/paths should be distinguished, simply by including
some kind of distinguishing mark with each error message.  For instance:

                        DRM_ERROR("unable to allocate a PPLL ONE\n");
                        DRM_ERROR("unable to allocate a PPLL TWO\n");
                DRM_ERROR("unable to allocate a PPLL THREE\n");
                DRM_ERROR("unable to allocate a PPLL FOUR\n");
                DRM_ERROR("unable to allocate a PPLL FIVE\n");

Whether the reported error is truly valid because of an actual hardware
limitation, or invalid because of faulty heuristics in the software, is a
separate topic.

Thanks
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel