All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, fengguang.wu@intel.com,
	luc.vanoostenryck@gmail.com, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] clockevents/drivers/timer-stm32: Fix build error spotted by kbuild test robot
Date: Mon, 08 Jun 2015 19:39:03 +0200	[thread overview]
Message-ID: <5575D337.1030901@linaro.org> (raw)
In-Reply-To: <1433667684-10057-1-git-send-email-mcoquelin.stm32@gmail.com>

On 06/07/2015 11:01 AM, Maxime Coquelin wrote:
> This patch fixes below error spotted by kbuild test robot when building
> with ARCH=ia64:
>
> All error/warnings (new ones prefixed by >>):
>
>          drivers/clocksource/timer-stm32.c:38:28: error: field 'evtdev' has incomplete type
>
>       struct clock_event_device evtdev;
>                                 ^
>
>          drivers/clocksource/timer-stm32.c:44:19: warning: 'enum clock_event_mode' declared inside parameter list
>
>                 struct clock_event_device *evtdev)
>
> The fix consists in making the STM32 timer depend on GENERIC_CLOCKEVENTS.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>

Sounds good.

Thomas, Ingo ? do you will take this patch directly ? Or do you prefer I 
queue it and waiting for more fixes to come before sending a PR ?

Thanks
   -- Daniel

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


  reply	other threads:[~2015-06-08 17:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-07  9:01 [PATCH] clockevents/drivers/timer-stm32: Fix build error spotted by kbuild test robot Maxime Coquelin
2015-06-08 17:39 ` Daniel Lezcano [this message]
2015-06-08 20:08   ` Thomas Gleixner
2015-06-08 20:47     ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5575D337.1030901@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.