All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gerecke <killertofu@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Ping Cheng <pinglinux@gmail.com>, Aaron Skomra <skomra@gmail.com>,
	Jiri Kosina <jkosina@suse.cz>,
	linux-input@vger.kernel.org,
	Jason Gerecke <jason.gerecke@wacom.com>
Subject: Re: [PATCH 0/5] HID: wacom: Support tablets with pen and touch on same interface
Date: Mon, 08 Jun 2015 10:49:41 -0700	[thread overview]
Message-ID: <5575D5B5.8040408@gmail.com> (raw)
In-Reply-To: <20150608155947.GD18162@mail.corp.redhat.com>

On 6/8/2015 8:59 AM, Benjamin Tissoires wrote:
> Hi again,
> 
> On Jun 03 2015 or thereabouts, Jason Gerecke wrote:
>> I've recently got my hands on a device which has an I2C sensor that sends
>> both pen and touch reports from a single interface. To userspace, it shows
>> up as a single input device which blends both the report types (e.g. it has
>> ABS_PRESSURE for the pen, and ABS_MT_POSITION_X for the touch). This patch
>> set modifies the driver to be able to handle devices which place both pen
>> and touch on a the same interface. It does this by treating the pen, touch,
>> and pad (which was already special-cased) independently. If a device has
>> the appropriate device_type, one or more of pen/touch/pad input devices
>> will be created, initialized, and used to send data to userspace.
>>
>> Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
> 
> So, besides the typo in 5/5, the series is:
> Reviewed-by: Bnejamin Tissoires <benjamin.tissoires@redhat.com>
> 
> I'll send a follow up patch to fix the Bamboo PAD extra interface once
> this will land in Jiri's tree.
> 
> Cheers,
> Benjamin
> 
> 
Just stumbled across a bug with wireless operation (missing pad device).
Hopefully Jiri hasn't merged anything yet :)

Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one /
(That is to say, eight) to the two, /
But you can’t take seven from three, /
So you look at the sixty-fours....

>>
>> Jason Gerecke (5):
>>   HID: wacom: Simplify 'wacom_update_name'
>>   HID: wacom: Treat features->device_type values as flags
>>   HID: wacom: Introduce a new WACOM_DEVICETYPE_PAD device_type
>>   HID: wacom: Split apart 'wacom_setup_pentouch_input_capabilites'
>>   HID: wacom: Introduce new 'touch_input' device
>>
>>  drivers/hid/wacom.h     |   4 +-
>>  drivers/hid/wacom_sys.c | 194 +++++++++++++++----------
>>  drivers/hid/wacom_wac.c | 379 ++++++++++++++++++++++++++----------------------
>>  drivers/hid/wacom_wac.h |  15 +-
>>  4 files changed, 332 insertions(+), 260 deletions(-)
>>
>> -- 
>> 2.4.1
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-06-08 17:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-04  1:18 [PATCH 0/5] HID: wacom: Support tablets with pen and touch on same interface Jason Gerecke
2015-06-04  1:18 ` [PATCH 1/5] HID: wacom: Simplify 'wacom_update_name' Jason Gerecke
2015-06-04  1:18 ` [PATCH 2/5] HID: wacom: Treat features->device_type values as flags Jason Gerecke
2015-06-04 18:59   ` Benjamin Tissoires
2015-06-04 21:04     ` Jason Gerecke
2015-06-04  1:18 ` [PATCH 3/5] HID: wacom: Introduce a new WACOM_DEVICETYPE_PAD device_type Jason Gerecke
2015-06-04  1:18 ` [PATCH 4/5] HID: wacom: Split apart 'wacom_setup_pentouch_input_capabilites' Jason Gerecke
2015-06-04  1:18 ` [PATCH 5/5] HID: wacom: Introduce new 'touch_input' device Jason Gerecke
2015-06-04 18:56   ` Benjamin Tissoires
2015-06-04 20:49     ` Jason Gerecke
2015-06-04 14:18 ` [PATCH 0/5] HID: wacom: Support tablets with pen and touch on same interface Benjamin Tissoires
2015-06-04 17:34   ` Jason Gerecke
2015-06-08 15:46     ` Benjamin Tissoires
2015-06-08 15:59 ` Benjamin Tissoires
2015-06-08 17:49   ` Jason Gerecke [this message]
2015-06-08 19:36     ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5575D5B5.8040408@gmail.com \
    --to=killertofu@gmail.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jason.gerecke@wacom.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=pinglinux@gmail.com \
    --cc=skomra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.