From: Johannes Berg <johannes@sipsolutions.net>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: "Kalle Valo" <kvalo@codeaurora.org>,
"Sumit Garg" <sumit.garg@linaro.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
kuba@kernel.org, netdev <netdev@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Matthias-Peter Schöpfer" <matthias.schoepfer@ithinx.io>,
"Berg Philipp (HAU-EDS)" <Philipp.Berg@liebherr.com>,
"Weitner Michael (HAU-EDS)" <Michael.Weitner@liebherr.com>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Loic Poulain" <loic.poulain@linaro.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] mac80211: fix race in ieee80211_register_hw()
Date: Mon, 06 Apr 2020 17:06:19 +0200 [thread overview]
Message-ID: <5575dfe84aa745a3c2a61e240c3d150dc8d9446f.camel@sipsolutions.net> (raw)
In-Reply-To: <CABPxzY++YMBPTV4quAkYvEAMfULjMXLkVfNzwocwubno5HO2Bw@mail.gmail.com> (sfid-20200406_162554_186372_29D110B6)
On Mon, 2020-04-06 at 19:55 +0530, Krishna Chaitanya wrote:
> > iw phy0 interface add wlan0 type station
> > ip link set wlan0 up
> Ah okay, got it, thanks. Very narrow window though :-) as the
> alloc_ordered_workqueue
> doesn't need RTNL and there is a long way to go to do if_add() from
> user and setup
> the driver for interrupts.
True, I do wonder how this is hit. Maybe something with no preempt and a
uevent triggering things?
> Again depends on the driver though, it
> should properly handle
> pending ieee80211_register_hw() with start().
It could, but it'd be really tricky. Much better to fix mac80211.
johannes
next prev parent reply other threads:[~2020-04-06 15:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 12:21 [PATCH] mac80211: fix race in ieee80211_register_hw() Sumit Garg
2020-04-06 12:44 ` Johannes Berg
2020-04-06 13:00 ` Sumit Garg
2020-04-06 12:44 ` Kalle Valo
2020-04-06 12:47 ` Johannes Berg
2020-04-06 12:52 ` Kalle Valo
2020-04-06 12:53 ` Johannes Berg
2020-04-06 13:04 ` Kalle Valo
2020-04-06 13:07 ` Johannes Berg
2020-04-06 13:21 ` Sumit Garg
2020-04-06 13:27 ` Kalle Valo
2020-04-06 13:55 ` Krishna Chaitanya
2020-04-06 14:01 ` Johannes Berg
2020-04-06 14:25 ` Krishna Chaitanya
2020-04-06 15:06 ` Johannes Berg [this message]
2020-04-06 18:08 ` Krishna Chaitanya
2020-04-07 6:42 ` Sumit Garg
2020-04-06 13:06 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5575dfe84aa745a3c2a61e240c3d150dc8d9446f.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Michael.Weitner@liebherr.com \
--cc=Philipp.Berg@liebherr.com \
--cc=chaitanya.mgit@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=matthias.schoepfer@ithinx.io \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.