All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kyungmin Park <kyungmin.park@samsung.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "linux-omap-open-source@linux.omap.com"
	<linux-omap-open-source@linux.omap.com>
Subject: [PATCH]  Apollon ethernet IRQ flags fix
Date: Thu, 16 Nov 2006 01:18:13 +0000 (GMT)	[thread overview]
Message-ID: <5576323.124231163639946665.JavaMail.weblogic@ep_ml21> (raw)

[-- Attachment #1: Type: text/plain, Size: 823 bytes --]

Hi, Tony

This patch brakes the apollon board.

apollon (omap2420) use IRQF_TRIGGER_RISING which means IRQF_TRIGGER_HIGH.

so we add it as below

#define SMC_IRQ_FLAGS		(machine_is_omap_apollon() ? IRQF_TRIGGER_HIGH : IRQF_TRIGGER_LOW)

please add this one

I tested it.

Thank you,
Kyungmin Park



------- Original Message -------
Sender : Tony Lindgren<tony@atomide.com> 
Date   : Nov 16, 2006 09:32
Title  : Re: [PATCH]  H4 / 2430SDP ethernet IRQ flags fix

* Syed Mohammed, Khasim <x0khasim@ti.com> [061116 01:36]:
> Hi Tony,
> 
> +#ifdef CONFIG_ARCH_OMAP1
> +#define	SMC_IRQ_FLAGS	(machine_is_omap_innovator() ?
> IRQF_TRIGGER_RISING : \
> +				IRQF_TRIGGER_FALLING)
> +#else
> +#define SMC_IRQ_FLAGS		IRQF_TRIGGER_LOW
> +#endif
> 
> This looks fine to me, please push this one.


[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



                 reply	other threads:[~2006-11-16  1:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5576323.124231163639946665.JavaMail.weblogic@ep_ml21 \
    --to=kyungmin.park@samsung.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.