From: Stephen Warren <swarren@wwwdotorg.org>
To: Eric Anholt <eric@anholt.net>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
linux-clk@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@linaro.org>
Subject: Re: [PATCH v3 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.
Date: Mon, 08 Jun 2015 19:56:07 -0600 [thread overview]
Message-ID: <557647B7.2030302@wwwdotorg.org> (raw)
In-Reply-To: <1433807940-15328-2-git-send-email-eric@anholt.net>
On 06/08/2015 05:58 PM, Eric Anholt wrote:
> Unfortunately, the clock manager's registers are not accessible by the
> ARM, so we have to request that the firmware modify our clocks for us.
>
> This driver only registers the clocks at the point they are requested
> by a client driver. This is partially to support returning
> -EPROBE_DEFER when the firmware driver isn't supported yet, but it
> also avoids issues with disabling "unused" clocks due to them not yet
> being connected to their consumers in the DT.
> diff --git a/drivers/clk/clk-raspberrypi.c b/drivers/clk/clk-raspberrypi.c
> +static int rpi_clk_set_state(struct clk_hw *hw, bool on)
> + if (ret || (packet[1] & (1 << 1))) {
A #define for the shift amount would be nice, so that this statement was
a bit more semantic.
Aside from that, the series,
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.
Date: Mon, 08 Jun 2015 19:56:07 -0600 [thread overview]
Message-ID: <557647B7.2030302@wwwdotorg.org> (raw)
In-Reply-To: <1433807940-15328-2-git-send-email-eric@anholt.net>
On 06/08/2015 05:58 PM, Eric Anholt wrote:
> Unfortunately, the clock manager's registers are not accessible by the
> ARM, so we have to request that the firmware modify our clocks for us.
>
> This driver only registers the clocks at the point they are requested
> by a client driver. This is partially to support returning
> -EPROBE_DEFER when the firmware driver isn't supported yet, but it
> also avoids issues with disabling "unused" clocks due to them not yet
> being connected to their consumers in the DT.
> diff --git a/drivers/clk/clk-raspberrypi.c b/drivers/clk/clk-raspberrypi.c
> +static int rpi_clk_set_state(struct clk_hw *hw, bool on)
> + if (ret || (packet[1] & (1 << 1))) {
A #define for the shift amount would be nice, so that this statement was
a bit more semantic.
Aside from that, the series,
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
next prev parent reply other threads:[~2015-06-09 1:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 23:58 [PATCH v3 1/7] dt/bindings: Add binding for the Raspberry Pi clock provider Eric Anholt
2015-06-08 23:58 ` Eric Anholt
2015-06-08 23:58 ` [PATCH v3 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver Eric Anholt
2015-06-08 23:58 ` Eric Anholt
2015-06-09 1:56 ` Stephen Warren [this message]
2015-06-09 1:56 ` Stephen Warren
2015-06-09 9:56 ` Lee Jones
2015-06-09 9:56 ` Lee Jones
2015-06-08 23:58 ` [PATCH v3 3/7] ARM: bcm2835: Add DT for the firmware clocks driver Eric Anholt
2015-06-08 23:58 ` Eric Anholt
2015-06-08 23:58 ` [PATCH v3 4/7] ARM: bcm2835: Drop never-used clock-frequency property of uart0 Eric Anholt
2015-06-08 23:58 ` Eric Anholt
2015-06-08 23:58 ` [PATCH v3 5/7] ARM: bcm2835: Drop the fixed sys_pclk Eric Anholt
2015-06-08 23:58 ` Eric Anholt
2015-06-08 23:58 ` [PATCH v3 6/7] ARM: bcm2835: Use the RPi firmware clocks for uart Eric Anholt
2015-06-08 23:58 ` Eric Anholt
2015-06-08 23:59 ` [PATCH v3 7/7] ARM: bcm2835: Tie SPI clock to the core clock rate Eric Anholt
2015-06-08 23:59 ` Eric Anholt
2015-06-09 0:03 ` [PATCH v3 1/7] dt/bindings: Add binding for the Raspberry Pi clock provider Eric Anholt
2015-06-09 0:03 ` Eric Anholt
2015-06-09 10:03 ` Lee Jones
2015-06-09 10:03 ` Lee Jones
2015-07-07 20:13 ` Eric Anholt
2015-07-07 20:13 ` Eric Anholt
2015-07-24 15:30 ` Lee Jones
2015-07-24 15:30 ` Lee Jones
2015-07-28 2:53 ` Stephen Warren
2015-07-28 2:53 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557647B7.2030302@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=eric@anholt.net \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mturquette@linaro.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.