All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Looijmans <mike.looijmans@topic.nl>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2 3/3] bitbake.conf: Set GITPKGV variable
Date: Tue, 9 Jun 2015 10:50:55 +0200	[thread overview]
Message-ID: <5576A8EF.7070800@topic.nl> (raw)
In-Reply-To: <1432276145-31264-4-git-send-email-mike.looijmans@topic.nl>

On 22-05-15 08:29, Mike Looijmans wrote:
> Set GITPKGV to mimic the meta-openembedded 'gitpkgv' class. This allows
> a recipe to simply set:
> PKGV="1.2+${GITPKGV}"
> And no longer needs to inherit gitpkgv class.
> ---
>   conf/bitbake.conf | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/conf/bitbake.conf b/conf/bitbake.conf
> index a35219d..5dafd52 100644
> --- a/conf/bitbake.conf
> +++ b/conf/bitbake.conf
> @@ -47,3 +47,4 @@ TARGET_ARCH = "${BUILD_ARCH}"
>   TMPDIR = "${TOPDIR}/tmp"
>   WORKDIR = "${TMPDIR}/work/${PF}"
>   PERSISTENT_DIR = "${TMPDIR}/cache"
> +GITPKGV = "${@bb.fetch2.get_srcrev(d, 'gitpkgv_revision')}"
>

This looked okay, but when put to a practical test, I noticed that this did 
not work at all. The GITPKGV variable is not set when building recipes, 
resulting in the literal string ${GITPKGV} appearing in version numbers of 
packages that try to use it.

It does work when I add this line to local.conf, but apparently bitbake.conf 
never actually gets parsed?




Kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Products
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
Telefax: +31 (0) 499 33 69 70
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail







  reply	other threads:[~2015-06-09  8:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22  6:29 [PATCH v2 0/3] RFC: Integrating gitpkgv functionality Mike Looijmans
2015-05-22  6:29 ` [PATCH v2 1/3] fetch2/__init__.py: Make get_srcrev output configurable Mike Looijmans
2015-05-22  6:29 ` [PATCH v2 2/3] fetch2/git.py: Add gitpkgv_revision alternative version information Mike Looijmans
2015-05-22  6:29 ` [PATCH v2 3/3] bitbake.conf: Set GITPKGV variable Mike Looijmans
2015-06-09  8:50   ` Mike Looijmans [this message]
2015-06-09  9:56     ` Paul Eggleton
2015-06-09 10:13       ` Richard Purdie
2015-05-23  7:16 ` [PATCH v2 0/3] RFC: Integrating gitpkgv functionality Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5576A8EF.7070800@topic.nl \
    --to=mike.looijmans@topic.nl \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.