From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86: adjust PV I/O emulation functions' types
Date: Tue, 9 Jun 2015 10:05:07 +0100 [thread overview]
Message-ID: <5576AC43.3020208@citrix.com> (raw)
In-Reply-To: <5576C6D7020000780008276E@mail.emea.novell.com>
On 09/06/15 09:58, Jan Beulich wrote:
> admin_io_okay(), guest_io_read(), and guest_io_write() all don't need
> their current "regs" parameter at all, and they don't use the vCPU
> passed to them for other than obtaining its domain. Drop the former and
> replace the latter by a struct domain pointer.
>
> pci_cfg_okay() returns a boolean type, and its "write" parameter is of
> boolean kind too.
>
> All of them get called for the current vCPU (and hence current domain)
> only, so name the domain parameters accordingly except in the
> admin_io_okay() case, which a subsequent patch will use for simplifying
> setup_io_bitmap().
>
> Latch current->domain into a local variable in emulate_privileged_op().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
prev parent reply other threads:[~2015-06-09 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 8:58 [PATCH] x86: adjust PV I/O emulation functions' types Jan Beulich
2015-06-09 9:05 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5576AC43.3020208@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.