From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86: adjust PV I/O emulation functions' types Date: Tue, 9 Jun 2015 10:05:07 +0100 Message-ID: <5576AC43.3020208@citrix.com> References: <5576C6D7020000780008276E@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z2FTJ-00040M-Rs for xen-devel@lists.xenproject.org; Tue, 09 Jun 2015 09:05:25 +0000 In-Reply-To: <5576C6D7020000780008276E@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Keir Fraser List-Id: xen-devel@lists.xenproject.org On 09/06/15 09:58, Jan Beulich wrote: > admin_io_okay(), guest_io_read(), and guest_io_write() all don't need > their current "regs" parameter at all, and they don't use the vCPU > passed to them for other than obtaining its domain. Drop the former and > replace the latter by a struct domain pointer. > > pci_cfg_okay() returns a boolean type, and its "write" parameter is of > boolean kind too. > > All of them get called for the current vCPU (and hence current domain) > only, so name the domain parameters accordingly except in the > admin_io_okay() case, which a subsequent patch will use for simplifying > setup_io_bitmap(). > > Latch current->domain into a local variable in emulate_privileged_op(). > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper