From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 1/4] x86/EFI: fix EFI_MEMORY_WP handling Date: Tue, 9 Jun 2015 14:57:06 +0100 Message-ID: <5576F0B2.7090300@citrix.com> References: <55770B190200007800082A2C@mail.emea.novell.com> <55770BB60200007800082A3F@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3074507507820694795==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z2K1f-0006G7-T3 for xen-devel@lists.xenproject.org; Tue, 09 Jun 2015 13:57:12 +0000 In-Reply-To: <55770BB60200007800082A3F@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org --===============3074507507820694795== Content-Type: multipart/alternative; boundary="------------060204090109030507030506" --------------060204090109030507030506 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit On 09/06/15 14:52, Jan Beulich wrote: > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper > > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -1195,7 +1195,7 @@ void __init efi_init_memory(void) > } > > if ( desc->Attribute & EFI_MEMORY_WP ) > - prot &= _PAGE_RW; > + prot &= ~_PAGE_RW; > if ( desc->Attribute & EFI_MEMORY_XP ) > prot |= _PAGE_NX; > > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel --------------060204090109030507030506 Content-Type: text/html; charset="windows-1252" Content-Transfer-Encoding: 7bit
On 09/06/15 14:52, Jan Beulich wrote:
Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>


--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1195,7 +1195,7 @@ void __init efi_init_memory(void)
         }
 
         if ( desc->Attribute & EFI_MEMORY_WP )
-            prot &= _PAGE_RW;
+            prot &= ~_PAGE_RW;
         if ( desc->Attribute & EFI_MEMORY_XP )
             prot |= _PAGE_NX;
 






_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--------------060204090109030507030506-- --===============3074507507820694795== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3074507507820694795==--