All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Shlomo Pongratz <shlomo.pongratz@huawei.com>,
	Shlomo Pongratz <shlomopongratz@gmail.com>,
	Pavel Fedin <p.fedin@samsung.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Shannon Zhao <shannon.zhao@linaro.org>,
	Ashok Kumar <ashoks@broadcom.com>,
	Igor Mammedov <imammedo@redhat.com>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>
Subject: Re: should KVM or userspace be the one which decides what MIPIDR/affinity values to assign to vcpus?
Date: Tue, 09 Jun 2015 15:00:23 +0100	[thread overview]
Message-ID: <5576F177.3090903@arm.com> (raw)
In-Reply-To: <CAFEAcA_y9DNLJTe+4kMBYObuKD82y0a05gsx6gOYZ8=Oo5LBGA@mail.gmail.com>

On 09/06/15 14:16, Peter Maydell wrote:
> On 9 June 2015 at 13:27, Marc Zyngier <marc.zyngier@arm.com> wrote:
>> On 09/06/15 12:24, Peter Maydell wrote:
>>> So either:
>>>  * QEMU needs to tell the kernel the MPIDR for each vCPU
>>>  * QEMU needs to ask the kernel the MPIDR for each vCPU
>>>
>>> Which is better? The latter is simpler and will work with
>>> existing kernels. The former would let us (for instance)
>>> use KVM when we're modelling (real world) boards which have
>>> particular cluster configurations (which might not match the
>>> kernel's current simplistic "always 16 CPUs at Aff0" setup).
>>
>> Given that it is userspace that provides the description of the
>> platform, it feels natural to let userspace set MPIDR accordingly.
>>
>> This will require some interesting rework in the kernel, but this
>> doesn't feel too bad.
> 
> On the other hand QEMU needs to keep working with current kernels,
> so we need the "ask the kernel" code at least for the moment.
> Probably needs a capability for "kernel allows userspace to
> set MPIDR" so we can adapt.

Yeah, what I had in mind was something along the lines of:
- kernel computes its "default MPDIR"
- kernel exposes a new capability "KVM_ARM_ALLOW_MPIDR_OVERRIDE" (or
something along those lines)
- userspace does the right thing.

	M.
-- 
Jazz is not dead. It just smells funny...

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <marc.zyngier@arm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Shlomo Pongratz <shlomo.pongratz@huawei.com>,
	Shlomo Pongratz <shlomopongratz@gmail.com>,
	Pavel Fedin <p.fedin@samsung.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Shannon Zhao <shannon.zhao@linaro.org>,
	Ashok Kumar <ashoks@broadcom.com>,
	Igor Mammedov <imammedo@redhat.com>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>
Subject: Re: [Qemu-devel] should KVM or userspace be the one which decides what MIPIDR/affinity values to assign to vcpus?
Date: Tue, 09 Jun 2015 15:00:23 +0100	[thread overview]
Message-ID: <5576F177.3090903@arm.com> (raw)
In-Reply-To: <CAFEAcA_y9DNLJTe+4kMBYObuKD82y0a05gsx6gOYZ8=Oo5LBGA@mail.gmail.com>

On 09/06/15 14:16, Peter Maydell wrote:
> On 9 June 2015 at 13:27, Marc Zyngier <marc.zyngier@arm.com> wrote:
>> On 09/06/15 12:24, Peter Maydell wrote:
>>> So either:
>>>  * QEMU needs to tell the kernel the MPIDR for each vCPU
>>>  * QEMU needs to ask the kernel the MPIDR for each vCPU
>>>
>>> Which is better? The latter is simpler and will work with
>>> existing kernels. The former would let us (for instance)
>>> use KVM when we're modelling (real world) boards which have
>>> particular cluster configurations (which might not match the
>>> kernel's current simplistic "always 16 CPUs at Aff0" setup).
>>
>> Given that it is userspace that provides the description of the
>> platform, it feels natural to let userspace set MPIDR accordingly.
>>
>> This will require some interesting rework in the kernel, but this
>> doesn't feel too bad.
> 
> On the other hand QEMU needs to keep working with current kernels,
> so we need the "ask the kernel" code at least for the moment.
> Probably needs a capability for "kernel allows userspace to
> set MPIDR" so we can adapt.

Yeah, what I had in mind was something along the lines of:
- kernel computes its "default MPDIR"
- kernel exposes a new capability "KVM_ARM_ALLOW_MPIDR_OVERRIDE" (or
something along those lines)
- userspace does the right thing.

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2015-06-09 13:50 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08 10:52 should KVM or userspace be the one which decides what MIPIDR/affinity values to assign to vcpus? Peter Maydell
2015-06-08 10:52 ` [Qemu-devel] " Peter Maydell
2015-06-09 10:52 ` Marc Zyngier
2015-06-09 10:52   ` [Qemu-devel] " Marc Zyngier
2015-06-09 11:24   ` Peter Maydell
2015-06-09 11:24     ` [Qemu-devel] " Peter Maydell
2015-06-09 11:54     ` Igor Mammedov
2015-06-09 11:54       ` [Qemu-devel] " Igor Mammedov
2015-06-09 12:27     ` Marc Zyngier
2015-06-09 12:27       ` [Qemu-devel] " Marc Zyngier
2015-06-09 13:16       ` Peter Maydell
2015-06-09 13:16         ` [Qemu-devel] " Peter Maydell
2015-06-09 14:00         ` Marc Zyngier [this message]
2015-06-09 14:00           ` Marc Zyngier
2015-06-09 14:01           ` Peter Maydell
2015-06-09 14:01             ` [Qemu-devel] " Peter Maydell
2015-06-09 14:35             ` Marc Zyngier
2015-06-09 14:35               ` [Qemu-devel] " Marc Zyngier
2015-06-10  9:54               ` Igor Mammedov
2015-06-10  9:54                 ` [Qemu-devel] " Igor Mammedov
2015-06-10 10:31                 ` Marc Zyngier
2015-06-10 10:31                   ` [Qemu-devel] " Marc Zyngier
2015-06-10 11:22                   ` Radim
2015-06-10 11:22                     ` [Qemu-devel] " Radim
2015-06-25  8:00     ` Christoffer Dall
2015-06-25  8:00       ` [Qemu-devel] " Christoffer Dall
2015-06-25  9:06       ` Peter Maydell
2015-06-25  9:06         ` [Qemu-devel] " Peter Maydell
2015-06-25 12:41         ` Christoffer Dall
2015-06-25 12:41           ` [Qemu-devel] " Christoffer Dall
2015-06-25 12:51           ` Peter Maydell
2015-06-25 12:51             ` [Qemu-devel] " Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5576F177.3090903@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=ashoks@broadcom.com \
    --cc=imammedo@redhat.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=p.fedin@samsung.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shannon.zhao@linaro.org \
    --cc=shlomo.pongratz@huawei.com \
    --cc=shlomopongratz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.