From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 2/4] EFI/early: add /mapbs to map
 EfiBootServices{Code, Data}
Date: Tue, 9 Jun 2015 16:26:05 +0100
Message-ID: <5577058D.2000202@citrix.com>
References: <55770B190200007800082A2C@mail.emea.novell.com>
	<55770BDF0200007800082A43@mail.emea.novell.com>	<5576F226.6080104@citrix.com>
	<20150609141144.GH15200@x230>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=595eaad67=Andrew.Cooper3@citrix.com>)
	id 1Z2LVm-0001jj-B3
	for xen-devel@lists.xenproject.org; Tue, 09 Jun 2015 15:32:22 +0000
In-Reply-To: <20150609141144.GH15200@x230>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 09/06/15 15:11, Konrad Rzeszutek Wilk wrote:
> On Tue, Jun 09, 2015 at 03:03:18PM +0100, Andrew Cooper wrote:
>> On 09/06/15 14:53, Jan Beulich wrote:
>>> From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>
>>> To help on certain platforms to run.
>>>
>>> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>
>>> --- a/xen/arch/x86/efi/efi-boot.h
>>> +++ b/xen/arch/x86/efi/efi-boot.h
>>> @@ -148,12 +148,16 @@ static void __init efi_arch_process_memo
>>>  
>>>          switch ( desc->Type )
>>>          {
>>> -        default:
>>> -            type = E820_RESERVED;
>>> -            break;
>>> -        case EfiConventionalMemory:
>>>          case EfiBootServicesCode:
>>>          case EfiBootServicesData:
>>> +            if ( map_bs )
>> if ( !map_bs ) surely?  It is the else case which sets a type of E820_RAM.
> We want the EfiBootServices{Code|Data} to be E820_RESERVED and this
> sets it to that if map_bs is set.
>
> If map_bs is not set then we treat it as E820_RAM.

Ah of course - sorry for the confusion.

~Andrew