From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 3/4] EFI: support default attributes to map
 Runtime service areas with none given
Date: Tue, 9 Jun 2015 16:30:20 +0100
Message-ID: <5577068C.5010705@citrix.com>
References: <55770B190200007800082A2C@mail.emea.novell.com>
	<55770C070200007800082A47@mail.emea.novell.com>	<5576F377.2020505@citrix.com>
	<557721CB0200007800082C1E@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=595eaad67=Andrew.Cooper3@citrix.com>)
	id 1Z2LUE-0001WA-Kz
	for xen-devel@lists.xenproject.org; Tue, 09 Jun 2015 15:30:46 +0000
In-Reply-To: <557721CB0200007800082C1E@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On 09/06/15 16:26, Jan Beulich wrote:
>>>> On 09.06.15 at 16:08, <andrew.cooper3@citrix.com> wrote:
>> On 09/06/15 14:53, Jan Beulich wrote:
>>> From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>
>>> For example on Dell machines we see:
>>>
>>> (XEN)  00000fed18000-00000fed19fff type=11 attr=8000000000000000
>>> (XEN) Unknown cachability for MFNs 0xfed18-0xfed19
>>>
>>> Let's allow them to be mapped as UC.
>>>
>>> We also alter the 'efi-rs' to be 'efi=rs' or 'efi=no-rs'.
>>>
>>> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>
>>> --- a/docs/misc/xen-command-line.markdown
>>> +++ b/docs/misc/xen-command-line.markdown
>>> @@ -617,12 +617,24 @@ Either force retrieval of monitor EDID i
>>>  disable it (edid=no). This option should not normally be required
>>>  except for debugging purposes.
>>>  
>>> -### efi-rs
>>> -> `= <boolean>`
>>> +### efi
>>> +> `= List of [ rs | attr ]`
>>> +
>>> +All options are of boolean kind and can be prefixed with `no-` to
>>> +effect the inverse meaning.
>>> +
>>> +> `rs`
>>>  
>>>  > Default: `true`
>>>  
>>> -Force or disable use of EFI runtime services.
>>> +>> Force or disable use of EFI runtime services.
>>> +
>>> +> `attr=uc`
>>> +
>>> +> Default: `off`
>> `false` would be more consistent with the rest of the rest of the document.
> That's how Konrad had it originally, and I intentionally changed it,
> as consistency with the rest of the doc seemed less important to
> me than for this to make sense (and "off" to me makes more sense
> than "false" here).
>
>> Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Please clarify whether this stands even without the above changed.

It stands.  I don't wish documentation quibbling to get in the way of
otherwise-good patches.

~Andrew