From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Message-ID: <557729A0.1030700@arm.com> Date: Tue, 09 Jun 2015 19:00:00 +0100 From: Marc Zyngier MIME-Version: 1.0 Subject: Re: [PATCH v5 1/2] arm64: kvm: allows kvm cpu hotplug References: <1432877920-12527-1-git-send-email-takahiro.akashi@linaro.org> <1432877920-12527-2-git-send-email-takahiro.akashi@linaro.org> In-Reply-To: <1432877920-12527-2-git-send-email-takahiro.akashi@linaro.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: AKASHI Takahiro , Catalin Marinas , Will Deacon , Mark Rutland Cc: "linux-arm-kernel@lists.infradead.org" , "linaro-kernel@lists.linaro.org" , "geoff@infradead.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "broonie@kernel.org" , "david.griego@linaro.org" , "christoffer.dall@linaro.org" , "freddy77@gmail.com" Hi Takahiro, On 29/05/15 06:38, AKASHI Takahiro wrote: > The current kvm implementation on arm64 does cpu-specific initialization > at system boot, and has no way to gracefully shutdown a core in terms of > kvm. This prevents, especially, kexec from rebooting the system on a boot > core in EL2. > > This patch adds a cpu tear-down function and also puts an existing cpu-init > code into a separate function, kvm_arch_hardware_disable() and > kvm_arch_hardware_enable() respectively. > We don't need arm64-specific cpu hotplug hook any more. > > Since this patch modifies common part of code between arm and arm64, one > stub definition, __cpu_reset_hyp_mode(), is added on arm side to avoid > compiling errors. > > Signed-off-by: AKASHI Takahiro This is starting to look good. Any chance you or Geoff could repost the whole series? This would help getting a better view of the whole thing, and hopefully put it on track for 4.3. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Tue, 09 Jun 2015 19:00:00 +0100 Subject: [PATCH v5 1/2] arm64: kvm: allows kvm cpu hotplug In-Reply-To: <1432877920-12527-2-git-send-email-takahiro.akashi@linaro.org> References: <1432877920-12527-1-git-send-email-takahiro.akashi@linaro.org> <1432877920-12527-2-git-send-email-takahiro.akashi@linaro.org> Message-ID: <557729A0.1030700@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Takahiro, On 29/05/15 06:38, AKASHI Takahiro wrote: > The current kvm implementation on arm64 does cpu-specific initialization > at system boot, and has no way to gracefully shutdown a core in terms of > kvm. This prevents, especially, kexec from rebooting the system on a boot > core in EL2. > > This patch adds a cpu tear-down function and also puts an existing cpu-init > code into a separate function, kvm_arch_hardware_disable() and > kvm_arch_hardware_enable() respectively. > We don't need arm64-specific cpu hotplug hook any more. > > Since this patch modifies common part of code between arm and arm64, one > stub definition, __cpu_reset_hyp_mode(), is added on arm side to avoid > compiling errors. > > Signed-off-by: AKASHI Takahiro This is starting to look good. Any chance you or Geoff could repost the whole series? This would help getting a better view of the whole thing, and hopefully put it on track for 4.3. Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753863AbbFISAK (ORCPT ); Tue, 9 Jun 2015 14:00:10 -0400 Received: from foss.arm.com ([217.140.101.70]:51742 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752304AbbFISAE (ORCPT ); Tue, 9 Jun 2015 14:00:04 -0400 Message-ID: <557729A0.1030700@arm.com> Date: Tue, 09 Jun 2015 19:00:00 +0100 From: Marc Zyngier Organization: ARM Ltd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: AKASHI Takahiro , Catalin Marinas , Will Deacon , Mark Rutland CC: "christoffer.dall@linaro.org" , "geoff@infradead.org" , "broonie@kernel.org" , "david.griego@linaro.org" , "freddy77@gmail.com" , "kexec@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linaro-kernel@lists.linaro.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v5 1/2] arm64: kvm: allows kvm cpu hotplug References: <1432877920-12527-1-git-send-email-takahiro.akashi@linaro.org> <1432877920-12527-2-git-send-email-takahiro.akashi@linaro.org> In-Reply-To: <1432877920-12527-2-git-send-email-takahiro.akashi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Takahiro, On 29/05/15 06:38, AKASHI Takahiro wrote: > The current kvm implementation on arm64 does cpu-specific initialization > at system boot, and has no way to gracefully shutdown a core in terms of > kvm. This prevents, especially, kexec from rebooting the system on a boot > core in EL2. > > This patch adds a cpu tear-down function and also puts an existing cpu-init > code into a separate function, kvm_arch_hardware_disable() and > kvm_arch_hardware_enable() respectively. > We don't need arm64-specific cpu hotplug hook any more. > > Since this patch modifies common part of code between arm and arm64, one > stub definition, __cpu_reset_hyp_mode(), is added on arm side to avoid > compiling errors. > > Signed-off-by: AKASHI Takahiro This is starting to look good. Any chance you or Geoff could repost the whole series? This would help getting a better view of the whole thing, and hopefully put it on track for 4.3. Thanks, M. -- Jazz is not dead. It just smells funny...