Re: what this would look like if the system is with templates.

[Ken Dreyer <kdreyer@redhat.com>]

On 06/09/2015 11:19 AM, Owen Synge wrote:
> 
>> we can be remove many hard coded values replaced with variable and that
>> probably will only grow in number for example
>>
>> 	%if 0%{?rhel} || 0%{?fedora}
>> 		--with-systemd-libexec-dir=/usr/libexec/ceph \
>> 	%endif
>> 	%if 0%{?opensuse} || 0%{?suse_version}
>> 		--with-systemd-libexec-dir=/usr/lib/ceph/ \
>> 	%endif
> 
> 	--with-systemd-libexec-dir=@systemd_libexec_dir@ \
> 
> No OS distribution specific rubbish needed :)

Passing an autoconf variable (@systemd_libexec_dir@) to an autoconf
argument (--with-systemd-libexec-dir) seems really over-complicated to me.

I don't see the issues with putting os-specific things in the .spec
file; that's how many other (non-Ceph) projects do it.

- Ken