From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f173.google.com (mail-pd0-f173.google.com [209.85.192.173]) by kanga.kvack.org (Postfix) with ESMTP id 905AB6B0032 for ; Tue, 9 Jun 2015 23:08:10 -0400 (EDT) Received: by pdjn11 with SMTP id n11so27547919pdj.0 for ; Tue, 09 Jun 2015 20:08:10 -0700 (PDT) Received: from mgwym04.jp.fujitsu.com (mgwym04.jp.fujitsu.com. [211.128.242.43]) by mx.google.com with ESMTPS id b5si11544728pdn.44.2015.06.09.20.08.08 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jun 2015 20:08:09 -0700 (PDT) Received: from m3050.s.css.fujitsu.com (msm.b.css.fujitsu.com [10.134.21.208]) by yt-mxq.gw.nic.fujitsu.com (Postfix) with ESMTP id B409CAC036D for ; Wed, 10 Jun 2015 12:08:05 +0900 (JST) Message-ID: <5577A9FF.4040603@jp.fujitsu.com> Date: Wed, 10 Jun 2015 12:07:43 +0900 From: Kamezawa Hiroyuki MIME-Version: 1.0 Subject: Re: [RFC PATCH 01/12] mm: add a new config to manage the code References: <55704A7E.5030507@huawei.com> <55704B0C.1000308@huawei.com> <55768B42.80503@jp.fujitsu.com> <5576BBA5.20005@huawei.com> In-Reply-To: <5576BBA5.20005@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Xishi Qiu Cc: Andrew Morton , nao.horiguchi@gmail.com, Yinghai Lu , "H. Peter Anvin" , Thomas Gleixner , mingo@elte.hu, Xiexiuqi , Hanjun Guo , "Luck, Tony" , Linux MM , LKML On 2015/06/09 19:10, Xishi Qiu wrote: > On 2015/6/9 14:44, Kamezawa Hiroyuki wrote: > >> On 2015/06/04 21:56, Xishi Qiu wrote: >>> This patch introduces a new config called "CONFIG_ACPI_MIRROR_MEMORY", it is >>> used to on/off the feature. >>> >>> Signed-off-by: Xishi Qiu >>> --- >>> mm/Kconfig | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/mm/Kconfig b/mm/Kconfig >>> index 390214d..4f2a726 100644 >>> --- a/mm/Kconfig >>> +++ b/mm/Kconfig >>> @@ -200,6 +200,14 @@ config MEMORY_HOTREMOVE >>> depends on MEMORY_HOTPLUG && ARCH_ENABLE_MEMORY_HOTREMOVE >>> depends on MIGRATION >>> >>> +config MEMORY_MIRROR >>> + bool "Address range mirroring support" >>> + depends on X86 && NUMA >>> + default y >>> + help >>> + This feature depends on hardware and firmware support. >>> + ACPI or EFI records the mirror info. >> >> default y...no runtime influence when the user doesn't use memory mirror ? >> > > It is a new feature, so how about like this: default y -> n? > It's okay to me. But it's better to check performance impact before merge because you modified core code of memory management. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932656AbbFJDIQ (ORCPT ); Tue, 9 Jun 2015 23:08:16 -0400 Received: from mgwkm03.jp.fujitsu.com ([202.219.69.170]:17275 "EHLO mgwkm03.jp.fujitsu.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752669AbbFJDIH (ORCPT ); Tue, 9 Jun 2015 23:08:07 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v2.3.2 X-SHieldMailCheckerPolicyVersion: FJ-ISEC-20150223 X-SHieldMailCheckerMailID: a7f75a1e9fa74df4899e6fbb4fd834d5 Message-ID: <5577A9FF.4040603@jp.fujitsu.com> Date: Wed, 10 Jun 2015 12:07:43 +0900 From: Kamezawa Hiroyuki User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Xishi Qiu CC: Andrew Morton , nao.horiguchi@gmail.com, Yinghai Lu , "H. Peter Anvin" , Thomas Gleixner , mingo@elte.hu, Xiexiuqi , Hanjun Guo , "Luck, Tony" , Linux MM , LKML Subject: Re: [RFC PATCH 01/12] mm: add a new config to manage the code References: <55704A7E.5030507@huawei.com> <55704B0C.1000308@huawei.com> <55768B42.80503@jp.fujitsu.com> <5576BBA5.20005@huawei.com> In-Reply-To: <5576BBA5.20005@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/06/09 19:10, Xishi Qiu wrote: > On 2015/6/9 14:44, Kamezawa Hiroyuki wrote: > >> On 2015/06/04 21:56, Xishi Qiu wrote: >>> This patch introduces a new config called "CONFIG_ACPI_MIRROR_MEMORY", it is >>> used to on/off the feature. >>> >>> Signed-off-by: Xishi Qiu >>> --- >>> mm/Kconfig | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/mm/Kconfig b/mm/Kconfig >>> index 390214d..4f2a726 100644 >>> --- a/mm/Kconfig >>> +++ b/mm/Kconfig >>> @@ -200,6 +200,14 @@ config MEMORY_HOTREMOVE >>> depends on MEMORY_HOTPLUG && ARCH_ENABLE_MEMORY_HOTREMOVE >>> depends on MIGRATION >>> >>> +config MEMORY_MIRROR >>> + bool "Address range mirroring support" >>> + depends on X86 && NUMA >>> + default y >>> + help >>> + This feature depends on hardware and firmware support. >>> + ACPI or EFI records the mirror info. >> >> default y...no runtime influence when the user doesn't use memory mirror ? >> > > It is a new feature, so how about like this: default y -> n? > It's okay to me. But it's better to check performance impact before merge because you modified core code of memory management. Thanks, -Kame