All of lore.kernel.org
 help / color / mirror / Atom feed
From: roopa <roopa@cumulusnetworks.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: Robert Shearman <rshearma@brocade.com>,
	ebiederm@xmission.com, netdev@vger.kernel.org,
	Vivek Venkatraman <vivek@cumulusnetworks.com>
Subject: Re: [PATCH WIP RFC 0/3] mpls: support for ler
Date: Wed, 10 Jun 2015 00:13:11 -0700	[thread overview]
Message-ID: <5577E387.4030206@cumulusnetworks.com> (raw)
In-Reply-To: <20150608225843.GA4602@pox.localdomain>

On 6/8/15, 3:58 PM, Thomas Graf wrote:
> I'll immediately ACK any series that supports both models and rebase
> my patches on top of it. I think we are on the right track overall.
>
>> I am trying to get my code on github to collaborate better. Stay tuned
>> (hopefully end of day today).
>
Robert/Thomas, All my changes are in the below repo under the 'mpls' branch.
https://github.com/CumulusNetworks/net-next
https://github.com/CumulusNetworks/iproute2

The last iproute2 commit has a sample usage.

The commits pushed to this tree do not contain support for the following 
yet (but working on it):
a) tunnel routes to work with tunnel RTA_OIF and a non-tunnel RTA_OIF:
The current commits in the tree assume a non-tunnel RTA_OIF.
If the tunnel driver has registered a dst_output func,  dst_output
is set to the tunnel dst output handler in the receive route lookup path 
which in turn does the encap
and xmits. Thomas had last suggested using a flag to skip the dst output 
handler re-direction
for cases where RTA_OIF is a special tunnel netdev and the tunnel driver 
xmit function
can do the encap. My current thinking is to pass the oif to the encap 
parse handler and the handler can set the flag on the tunnel state. And 
this flag can then be used to skip the dst_output re-direction.
This change should be trivial will fix it soon.

b) make RTA_OIF optional and do a fib lookup.

keep your suggestions/feedback coming...

thanks,
Roopa

  reply	other threads:[~2015-06-10  7:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 14:21 [PATCH WIP RFC 0/3] mpls: support for ler Roopa Prabhu
2015-06-05  9:14 ` Thomas Graf
2015-06-05 14:16   ` roopa
2015-06-05 15:26     ` Robert Shearman
2015-06-06  2:54       ` roopa
2015-06-08 12:33         ` Thomas Graf
2015-06-08 15:17           ` roopa
2015-06-08 22:58             ` Thomas Graf
2015-06-10  7:13               ` roopa [this message]
2015-06-12 16:15                 ` roopa
2015-06-05 14:31   ` Robert Shearman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5577E387.4030206@cumulusnetworks.com \
    --to=roopa@cumulusnetworks.com \
    --cc=ebiederm@xmission.com \
    --cc=netdev@vger.kernel.org \
    --cc=rshearma@brocade.com \
    --cc=tgraf@suug.ch \
    --cc=vivek@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.