Re: Regression inside omap3isp/resizer (was: 3fdfeda causes a regression)

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Florian,

Sorry for the late reply.

On Monday 23 December 2013 22:47:45 Florian Vaussard wrote:
> On 12/17/2013 11:42 AM, Florian Vaussard wrote:
> > Hello Laurent,
> > 
> > I was working on having a functional IOMMU/ISP for 3.14, and had an
> > issue with an image completely distorted. Comparing with another kernel,
> > I saw that PRV_HORZ_INFO and PRV_VERT_INFO differed. On the newer
> > kernel, sph, eph, svl, and slv were all off-by 2, causing my final image
> > to miss 4 pixels on each line, thus distorting the result.
> > 
> > Your commit 3fdfedaaa7f243f3347084231c64f6c1be0ba131 '[media] omap3isp:
> > preview: Lower the crop margins' indeed changes PRV_HORZ_INFO and
> > PRV_VERT_INFO by removing the if() condition. Reverting it made my image
> > to be valid again.
> > 
> > FYI, my pipeline is:
> > 
> > MT9V032 (SGRBG10 752x480) -> CCDC -> PREVIEW (UYVY 752x480) -> RESIZER
> > -> out
> 
> Just an XMAS ping on this :-) Do you have any idea how to solve this
> without reverting the patch?

The patch indeed changed the preview engine margins, but the change is 
supposed to be handled by applications. As a base for this discussion could 
you please provide the media-ctl -p output before and after applying the patch 
? You can strip the unrelated media entities out of the output.

-- 
Regards,

Laurent Pinchart