All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] sched:Prefer numa hotness over cache hotness
Date: Wed, 10 Jun 2015 10:12:37 -0400	[thread overview]
Message-ID: <557845D5.6060800@redhat.com> (raw)
In-Reply-To: <1433919816-20386-1-git-send-email-srikar@linux.vnet.ibm.com>

On 06/10/2015 03:03 AM, Srikar Dronamraju wrote:
> The current load balancer may not try to prevent a task from moving out
> of a preferred node to a less preferred node. The reason for this being:
> 
> - Since sched features NUMA and NUMA_RESIST_LOWER are disabled by
>   default, migrate_degrades_locality() always returns false.
> 
> - Even if NUMA_RESIST_LOWER were to be enabled, if its cache hot,
>   migrate_degrades_locality() never gets called.
> 
> The above behaviour can mean that tasks can move out of their preferred
> node but they may be eventually be brought back to their preferred node
> by numa balancer (due to higher numa faults).
> 
> To avoid the above, this commit merges migrate_degrades_locality() and
> migrate_improves_locality(). It also replaces 3 sched features NUMA,
> NUMA_FAVOUR_HIGHER and NUMA_RESIST_LOWER by a single sched feature NUMA.

I had been looking at merging the two at well, but ran
into a dead end because I failed to reorder NUMA and
cache_hot testing.  Nice work.

> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

Acked-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed

  parent reply	other threads:[~2015-06-10 14:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10  7:03 [PATCH] sched:Prefer numa hotness over cache hotness Srikar Dronamraju
2015-06-10  7:03 ` Performance numbers with prefer " Srikar Dronamraju
2015-06-10 14:12 ` Rik van Riel [this message]
2015-06-11 14:01 ` [PATCH] sched:Prefer " Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557845D5.6060800@redhat.com \
    --to=riel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.